[PATCH RFC 00/10] RFC: Drop qemu.qmp from qemu.git

John Snow posted 10 patches 2 weeks, 2 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251028220342.1407883-1-jsnow@redhat.com
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
.gitlab-ci.d/buildtest.yml                    |    1 +
python/qemu/qmp/__init__.py                   |   60 -
python/qemu/qmp/error.py                      |   53 -
python/qemu/qmp/events.py                     |  751 -----------
python/qemu/qmp/legacy.py                     |  339 -----
python/qemu/qmp/message.py                    |  217 ----
python/qemu/qmp/models.py                     |  146 ---
python/qemu/qmp/protocol.py                   | 1101 -----------------
python/qemu/qmp/py.typed                      |    0
python/qemu/qmp/qmp_client.py                 |  732 -----------
python/qemu/qmp/qmp_shell.py                  |  689 -----------
python/qemu/qmp/qmp_tui.py                    |  665 ----------
python/qemu/qmp/util.py                       |  150 ---
python/qemu/utils/qom_fuse.py                 |    1 -
python/scripts/mkvenv.py                      |   30 +-
python/scripts/vendor.py                      |    2 +
python/setup.cfg                              |   32 +-
python/tests/minreqs.txt                      |    8 +-
python/tests/protocol.py                      |  596 ---------
python/wheels/qemu_qmp-0.0.5-py3-none-any.whl |  Bin 0 -> 72263 bytes
pythondeps.toml                               |    7 +-
scripts/qapi/introspect.py                    |    2 +-
tests/Makefile.include                        |    2 +-
tests/meson.build                             |   15 +
tests/qemu-iotests/meson.build                |    2 +-
25 files changed, 55 insertions(+), 5546 deletions(-)
delete mode 100644 python/qemu/qmp/__init__.py
delete mode 100644 python/qemu/qmp/error.py
delete mode 100644 python/qemu/qmp/events.py
delete mode 100644 python/qemu/qmp/legacy.py
delete mode 100644 python/qemu/qmp/message.py
delete mode 100644 python/qemu/qmp/models.py
delete mode 100644 python/qemu/qmp/protocol.py
delete mode 100644 python/qemu/qmp/py.typed
delete mode 100644 python/qemu/qmp/qmp_client.py
delete mode 100644 python/qemu/qmp/qmp_shell.py
delete mode 100644 python/qemu/qmp/qmp_tui.py
delete mode 100644 python/qemu/qmp/util.py
delete mode 100644 python/tests/protocol.py
create mode 100644 python/wheels/qemu_qmp-0.0.5-py3-none-any.whl
[PATCH RFC 00/10] RFC: Drop qemu.qmp from qemu.git
Posted by John Snow 2 weeks, 2 days ago
This is an RFC, there's definitely a ton of nits here to smooth over,
but I need help.

1) The custom target I added to invoke the mkvenv ensure_group command
to install test deps uses a junk output target that isn't actually
pointed at the blank group file that mkvenv creates, because it's in
another directory and meson doesn't like allowing you to specify targets
in other directories. I'm not sure what the best way to fix this is...

2) I only made iotests depend on this new custom target, because it was
easy to do. I was not immediately sure what the correct way to make the
functests depend on this new target was, so that needs adjusted.

3) I did not remove the legacy "check-venv" target yet as with this
patchset I have split apart the testing dependencies into the core
dependencies and the functional dependencies. Ideally, "check-venv" is
removed and we add a second custom target to meson that replaces this
legacy target.

4) I have so far not made any provisions to allow running iotest's check
script from outside of the build system, but I am hoping it won't be too
difficult to achieve ...

5) There's likely a bunch of python tests that are now yapping and
yelping after I so cruelly removed one of our libraries from out of the
tree, I will smooth those over before the final push, but I can work on
this in parallel while I wait for feedback and advice on the above
items.

John Snow (10):
  python/mkvenv: ensure HAVE_LIB variables are actually constants
  python/qapi: Add an ignore for Pylint 4.x
  python/mkvenv: create timestamp file for each group "ensured"
  python/mkvenv: bump 'qemu.qmp' dependency for testdeps
  python/mkvenv: rename 'testdeps' to 'functests'
  python/mkvenv: add "tests" dependency group
  meson: create meson custom target for python test dependencies
  meson: make iotests depend on pyvent_test_deps
  python: quote dotted dependency keys
  python: delete qemu.qmp

 .gitlab-ci.d/buildtest.yml                    |    1 +
 python/qemu/qmp/__init__.py                   |   60 -
 python/qemu/qmp/error.py                      |   53 -
 python/qemu/qmp/events.py                     |  751 -----------
 python/qemu/qmp/legacy.py                     |  339 -----
 python/qemu/qmp/message.py                    |  217 ----
 python/qemu/qmp/models.py                     |  146 ---
 python/qemu/qmp/protocol.py                   | 1101 -----------------
 python/qemu/qmp/py.typed                      |    0
 python/qemu/qmp/qmp_client.py                 |  732 -----------
 python/qemu/qmp/qmp_shell.py                  |  689 -----------
 python/qemu/qmp/qmp_tui.py                    |  665 ----------
 python/qemu/qmp/util.py                       |  150 ---
 python/qemu/utils/qom_fuse.py                 |    1 -
 python/scripts/mkvenv.py                      |   30 +-
 python/scripts/vendor.py                      |    2 +
 python/setup.cfg                              |   32 +-
 python/tests/minreqs.txt                      |    8 +-
 python/tests/protocol.py                      |  596 ---------
 python/wheels/qemu_qmp-0.0.5-py3-none-any.whl |  Bin 0 -> 72263 bytes
 pythondeps.toml                               |    7 +-
 scripts/qapi/introspect.py                    |    2 +-
 tests/Makefile.include                        |    2 +-
 tests/meson.build                             |   15 +
 tests/qemu-iotests/meson.build                |    2 +-
 25 files changed, 55 insertions(+), 5546 deletions(-)
 delete mode 100644 python/qemu/qmp/__init__.py
 delete mode 100644 python/qemu/qmp/error.py
 delete mode 100644 python/qemu/qmp/events.py
 delete mode 100644 python/qemu/qmp/legacy.py
 delete mode 100644 python/qemu/qmp/message.py
 delete mode 100644 python/qemu/qmp/models.py
 delete mode 100644 python/qemu/qmp/protocol.py
 delete mode 100644 python/qemu/qmp/py.typed
 delete mode 100644 python/qemu/qmp/qmp_client.py
 delete mode 100644 python/qemu/qmp/qmp_shell.py
 delete mode 100644 python/qemu/qmp/qmp_tui.py
 delete mode 100644 python/qemu/qmp/util.py
 delete mode 100644 python/tests/protocol.py
 create mode 100644 python/wheels/qemu_qmp-0.0.5-py3-none-any.whl

-- 
2.51.0