[PATCH 0/2] hw/ipmi/ipmi_bmc_sim: Get/set fake LAN config

Yunpeng Yang posted 2 patches 3 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251028180115.1098433-1-yunpeng.yang@nutanix.com
Maintainers: Corey Minyard <minyard@acm.org>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
There is a newer version of this series
hw/ipmi/ipmi_bmc_sim.c      | 407 +++++++++++++++++++++++++++++++++++-
include/hw/ipmi/ipmi.h      |   1 +
qemu-options.hx             |  26 +++
tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++
4 files changed, 567 insertions(+), 10 deletions(-)
[PATCH 0/2] hw/ipmi/ipmi_bmc_sim: Get/set fake LAN config
Posted by Yunpeng Yang 3 months, 1 week ago
Support for a fake LAN channel is added to the device `ipmi_bmc_sim`.
Although there is no real LAN channel, some testing processes which
require interactions with BMC LAN channel will become easier.

There's another device `ipmi_bmc_extern` which works together with some
external BMC simulator, e.g., `ipmi_sim`. More comprehensive BMC
simulation can be achieved with `ipmi_bmc_extern`. However,
`ipmi_bmc_sim` is more light-weight and is built into QEMU.

Yunpeng Yang (2):
  hw/ipmi/ipmi_bmc_sim: Support getting fake LAN channel config
  hw/ipmi/ipmi_bmc_sim: Support setting fake LAN channel config

 hw/ipmi/ipmi_bmc_sim.c      | 407 +++++++++++++++++++++++++++++++++++-
 include/hw/ipmi/ipmi.h      |   1 +
 qemu-options.hx             |  26 +++
 tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++
 4 files changed, 567 insertions(+), 10 deletions(-)

-- 
2.43.7

Re: [PATCH 0/2] hw/ipmi/ipmi_bmc_sim: Get/set fake LAN config
Posted by Corey Minyard 2 months, 2 weeks ago
On Tue, Oct 28, 2025 at 06:01:18PM +0000, Yunpeng Yang wrote:
> Support for a fake LAN channel is added to the device `ipmi_bmc_sim`.
> Although there is no real LAN channel, some testing processes which
> require interactions with BMC LAN channel will become easier.
> 
> There's another device `ipmi_bmc_extern` which works together with some
> external BMC simulator, e.g., `ipmi_sim`. More comprehensive BMC
> simulation can be achieved with `ipmi_bmc_extern`. However,
> `ipmi_bmc_sim` is more light-weight and is built into QEMU.

I apologize for the time on this, it slipped between the cracks.

These both look good.  I can give a:

Reviewed-by: Corey Minyard <corey@minyard.net>

or 

Acked-by: Corey Minyard <corey@minyard.net>

or I can take it into my tree if you aren't bringing it in any place
else.

One thing you should try is doing a migration between a version 1 and
version 2 device, and between two version 2 devices, just to be sure
migration still works.  Assuming you haven't done this already.

-corey

> 
> Yunpeng Yang (2):
>   hw/ipmi/ipmi_bmc_sim: Support getting fake LAN channel config
>   hw/ipmi/ipmi_bmc_sim: Support setting fake LAN channel config
> 
>  hw/ipmi/ipmi_bmc_sim.c      | 407 +++++++++++++++++++++++++++++++++++-
>  include/hw/ipmi/ipmi.h      |   1 +
>  qemu-options.hx             |  26 +++
>  tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++
>  4 files changed, 567 insertions(+), 10 deletions(-)
> 
> -- 
> 2.43.7
>
Re: [PATCH 0/2] hw/ipmi/ipmi_bmc_sim: Get/set fake LAN config
Posted by Yunpeng Yang 2 months, 2 weeks ago
Hello Corey,

Thank you for your reply.

Please add tags or take the patches into your tree at your discretion.
I'm not bringing the patches in any place else.

I haven't tested migration between a version 1 and a version 2 device.
I'll do a test and tell you the result. Thank you for your suggestion.

Kind regards,
Yunpeng



________________________________
From: Corey Minyard <corey@minyard.net>
Sent: Monday, November 24, 2025 20:54
To: Yunpeng Yang <yunpeng.yang@nutanix.com>
Cc: minyard@acm.org <minyard@acm.org>; farosas@suse.de <farosas@suse.de>; lvivier@redhat.com <lvivier@redhat.com>; pbonzini@redhat.com <pbonzini@redhat.com>; qemu-devel@nongnu.org <qemu-devel@nongnu.org>; Mark Cave-Ayland <mark.caveayland@nutanix.com>; Jonathan Davies <jond@nutanix.com>; cornelia.huck@de.ibm.com <cornelia.huck@de.ibm.com>
Subject: Re: [PATCH 0/2] hw/ipmi/ipmi_bmc_sim: Get/set fake LAN config

!-------------------------------------------------------------------|
  CAUTION: External Email

|-------------------------------------------------------------------!

On Tue, Oct 28, 2025 at 06:01:18PM +0000, Yunpeng Yang wrote:
> Support for a fake LAN channel is added to the device `ipmi_bmc_sim`.
> Although there is no real LAN channel, some testing processes which
> require interactions with BMC LAN channel will become easier.
>
> There's another device `ipmi_bmc_extern` which works together with some
> external BMC simulator, e.g., `ipmi_sim`. More comprehensive BMC
> simulation can be achieved with `ipmi_bmc_extern`. However,
> `ipmi_bmc_sim` is more light-weight and is built into QEMU.

I apologize for the time on this, it slipped between the cracks.

These both look good.  I can give a:

Reviewed-by: Corey Minyard <corey@minyard.net>

or

Acked-by: Corey Minyard <corey@minyard.net>

or I can take it into my tree if you aren't bringing it in any place
else.

One thing you should try is doing a migration between a version 1 and
version 2 device, and between two version 2 devices, just to be sure
migration still works.  Assuming you haven't done this already.

-corey

>
> Yunpeng Yang (2):
>   hw/ipmi/ipmi_bmc_sim: Support getting fake LAN channel config
>   hw/ipmi/ipmi_bmc_sim: Support setting fake LAN channel config
>
>  hw/ipmi/ipmi_bmc_sim.c      | 407 +++++++++++++++++++++++++++++++++++-
>  include/hw/ipmi/ipmi.h      |   1 +
>  qemu-options.hx             |  26 +++
>  tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++
>  4 files changed, 567 insertions(+), 10 deletions(-)
>
> --
> 2.43.7
>
Re: [PATCH 0/2] hw/ipmi/ipmi_bmc_sim: Get/set fake LAN config
Posted by Yunpeng Yang 2 months, 1 week ago
Hello Corey,

I have done a VM migration test from a v1 `ipmi_bmc_sim` qemu to a v2 `ipmi_bmc_sim` qemu. The migration was successful. The VM had `ipmi_bmc_sim` configured but with no LAN channel.
A v2 to v2 migration with LAN channel was also successful.

Kind regards,
Yunpeng

________________________________
From: Yunpeng Yang <yunpeng.yang@nutanix.com>
Sent: Wednesday, November 26, 2025 18:04
To: corey@minyard.net <corey@minyard.net>
Cc: minyard@acm.org <minyard@acm.org>; farosas@suse.de <farosas@suse.de>; lvivier@redhat.com <lvivier@redhat.com>; pbonzini@redhat.com <pbonzini@redhat.com>; qemu-devel@nongnu.org <qemu-devel@nongnu.org>; Mark Cave-Ayland <mark.caveayland@nutanix.com>; Jonathan Davies <jond@nutanix.com>; cornelia.huck@de.ibm.com <cornelia.huck@de.ibm.com>
Subject: Re: [PATCH 0/2] hw/ipmi/ipmi_bmc_sim: Get/set fake LAN config

Hello Corey,

Thank you for your reply.

Please add tags or take the patches into your tree at your discretion.
I'm not bringing the patches in any place else.

I haven't tested migration between a version 1 and a version 2 device.
I'll do a test and tell you the result. Thank you for your suggestion.

Kind regards,
Yunpeng



________________________________
From: Corey Minyard <corey@minyard.net>
Sent: Monday, November 24, 2025 20:54
To: Yunpeng Yang <yunpeng.yang@nutanix.com>
Cc: minyard@acm.org <minyard@acm.org>; farosas@suse.de <farosas@suse.de>; lvivier@redhat.com <lvivier@redhat.com>; pbonzini@redhat.com <pbonzini@redhat.com>; qemu-devel@nongnu.org <qemu-devel@nongnu.org>; Mark Cave-Ayland <mark.caveayland@nutanix.com>; Jonathan Davies <jond@nutanix.com>; cornelia.huck@de.ibm.com <cornelia.huck@de.ibm.com>
Subject: Re: [PATCH 0/2] hw/ipmi/ipmi_bmc_sim: Get/set fake LAN config

!-------------------------------------------------------------------|
  CAUTION: External Email

|-------------------------------------------------------------------!

On Tue, Oct 28, 2025 at 06:01:18PM +0000, Yunpeng Yang wrote:
> Support for a fake LAN channel is added to the device `ipmi_bmc_sim`.
> Although there is no real LAN channel, some testing processes which
> require interactions with BMC LAN channel will become easier.
>
> There's another device `ipmi_bmc_extern` which works together with some
> external BMC simulator, e.g., `ipmi_sim`. More comprehensive BMC
> simulation can be achieved with `ipmi_bmc_extern`. However,
> `ipmi_bmc_sim` is more light-weight and is built into QEMU.

I apologize for the time on this, it slipped between the cracks.

These both look good.  I can give a:

Reviewed-by: Corey Minyard <corey@minyard.net>

or

Acked-by: Corey Minyard <corey@minyard.net>

or I can take it into my tree if you aren't bringing it in any place
else.

One thing you should try is doing a migration between a version 1 and
version 2 device, and between two version 2 devices, just to be sure
migration still works.  Assuming you haven't done this already.

-corey

>
> Yunpeng Yang (2):
>   hw/ipmi/ipmi_bmc_sim: Support getting fake LAN channel config
>   hw/ipmi/ipmi_bmc_sim: Support setting fake LAN channel config
>
>  hw/ipmi/ipmi_bmc_sim.c      | 407 +++++++++++++++++++++++++++++++++++-
>  include/hw/ipmi/ipmi.h      |   1 +
>  qemu-options.hx             |  26 +++
>  tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++
>  4 files changed, 567 insertions(+), 10 deletions(-)
>
> --
> 2.43.7
>