[PATCH v4 0/2] migration: vmsd errp handlers: return bool

Vladimir Sementsov-Ogievskiy posted 2 patches 2 weeks, 3 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251028130738.29037-1-vsementsov@yandex-team.ru
Maintainers: Stefan Berger <stefanb@linux.vnet.ibm.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>
backends/tpm/tpm_emulator.c | 63 +++++++++++++++++++++++--------------
migration/vmstate.c         |  1 +
2 files changed, 40 insertions(+), 24 deletions(-)
[PATCH v4 0/2] migration: vmsd errp handlers: return bool
Posted by Vladimir Sementsov-Ogievskiy 2 weeks, 3 days ago
Hi.

Finally, I understood, that there is no real benefit in converting
these new APIs to bool, as it will break plans of converting all
other handlers to new API.

So, only unrelated fixes are kept in the series, maintainers may
pick them in separate if convenient.

v4:
01: add r-b by Stefan
02: rework to better patch (and fix one more similar issue)

Vladimir Sementsov-Ogievskiy (2):
  migration: vmstate_save_state_v(): fix error path
  tmp_emulator: improve and fix use of errp

 backends/tpm/tpm_emulator.c | 63 +++++++++++++++++++++++--------------
 migration/vmstate.c         |  1 +
 2 files changed, 40 insertions(+), 24 deletions(-)

-- 
2.48.1
Re: [PATCH v4 0/2] migration: vmsd errp handlers: return bool
Posted by Peter Xu 2 weeks ago
On Tue, Oct 28, 2025 at 04:07:36PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi.
> 
> Finally, I understood, that there is no real benefit in converting
> these new APIs to bool, as it will break plans of converting all
> other handlers to new API.
> 
> So, only unrelated fixes are kept in the series, maintainers may
> pick them in separate if convenient.
> 
> v4:
> 01: add r-b by Stefan
> 02: rework to better patch (and fix one more similar issue)

Stefan, are you ok on patch 2?

If no objections, I can pick this up for 10.2.

Thanks,

-- 
Peter Xu
Re: [PATCH v4 0/2] migration: vmsd errp handlers: return bool
Posted by Vladimir Sementsov-Ogievskiy 2 weeks, 2 days ago
On 28.10.25 16:07, Vladimir Sementsov-Ogievskiy wrote:
> Hi.
> 
> Finally, I understood, that there is no real benefit in converting
> these new APIs to bool, as it will break plans of converting all
> other handlers to new API.
> 
> So, only unrelated fixes are kept in the series, maintainers may
> pick them in separate if convenient.
> 
> v4:
> 01: add r-b by Stefan
> 02: rework to better patch (and fix one more similar issue)

After analysis by Peter ( https://lore.kernel.org/qemu-devel/aQDdRn8t0B8oE3gf@x1.local/ ), I've added 03 and 04 back.

Unfortunately I missed that I should use --no-thread together with --in-reply-to.. That's why 04 is reply to 03.

> 
> Vladimir Sementsov-Ogievskiy (2):
>    migration: vmstate_save_state_v(): fix error path
>    tmp_emulator: improve and fix use of errp
> 
>   backends/tpm/tpm_emulator.c | 63 +++++++++++++++++++++++--------------
>   migration/vmstate.c         |  1 +
>   2 files changed, 40 insertions(+), 24 deletions(-)
> 


-- 
Best regards,
Vladimir