migration: Fix error propagation regression and memory leak

[PATCH v2 0/2] migration: Fix error propagation regression and memory leak

Arun Menon posted 2 patches 2 weeks, 3 days ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251028-solve._5Ferror._5Ffatal._5Fregression-v2-0-dab24c808a28@redhat.com

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>, Dmitry Osipenko <dmitry.osipenko@collabora.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Cornelia Huck <cohuck@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>, Nicholas Piggin <npiggin@gmail.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>

hw/display/virtio-gpu.c | 19 ++++++++++++++-----
hw/pci/pci.c            | 13 +++++++++++--
hw/s390x/virtio-ccw.c   | 15 +++++++++++++--
hw/scsi/spapr_vscsi.c   |  9 +++++++--
hw/virtio/virtio-mmio.c | 15 +++++++++++++--
hw/virtio/virtio-pci.c  | 15 +++++++++++++--
hw/virtio/virtio.c      | 10 +++++++---
migration/savevm.c      |  1 +
8 files changed, 79 insertions(+), 18 deletions(-)

Expand all Fold all

[PATCH v2 0/2] migration: Fix error propagation regression and memory leak

Posted by Arun Menon 2 weeks, 3 days ago

Hi,

This series fixes the following:

commit c632ffbd74 introduced a regression of passing error_fatal
to vmstate_load_state() and vmstate_save_state() functions.
This will not allow us to propagate the error back to the caller.

commit 94272d9b45 introduced a memory leak in postcopy_ram_listen_thread().
We need to free the local_err object in the if clause as well.

---
Changes in v2:
- Refactoring of the return statement in virtio_gpu_load().
- Add another patch to fix the memory leak in postcopy_ram_listen_thread()
- Link to v1: https://lore.kernel.org/qemu-devel/20251024-solve_error_fatal_regression-v1-1-d26e6cbd0a7e@redhat.com

---
Arun Menon (2):
      migration: Fix regression of passing error_fatal into vmstate_load_state()
      migration: Fix memory leak in postcopy_ram_listen_thread()

 hw/display/virtio-gpu.c | 19 ++++++++++++++-----
 hw/pci/pci.c            | 13 +++++++++++--
 hw/s390x/virtio-ccw.c   | 15 +++++++++++++--
 hw/scsi/spapr_vscsi.c   |  9 +++++++--
 hw/virtio/virtio-mmio.c | 15 +++++++++++++--
 hw/virtio/virtio-pci.c  | 15 +++++++++++++--
 hw/virtio/virtio.c      | 10 +++++++---
 migration/savevm.c      |  1 +
 8 files changed, 79 insertions(+), 18 deletions(-)
---
base-commit: 36076d24f04ea9dc3357c0fbe7bb14917375819c
change-id: 20251024-solve_error_fatal_regression-301763debd8f

Best regards,
-- 
Arun Menon <armenon@redhat.com>