make gdbus-codegen optional, not required by passt

[PATCH] make gdbus-codegen optional, not required by passt

Nicolas PARLANT posted 1 patch 2 weeks, 4 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251027113910.25379-2-nicolas.parlant@parhuet.fr

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>

meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH] make gdbus-codegen optional, not required by passt

Posted by Nicolas PARLANT 2 weeks, 4 days ago

passt needs gio but not gdbus-codegen. Make gdbus-codegen optional,
dbus_display which requires it will still fail as expected.

Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
---
 meson.build | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meson.build b/meson.build
index c5710a6a47..3f7c973127 100644
--- a/meson.build
+++ b/meson.build
@@ -1126,8 +1126,7 @@ if not get_option('gio').auto() or have_system
     gio = not_found
   endif
   if gio.found()
-    gdbus_codegen = find_program('gdbus-codegen',
-                                 required: get_option('gio'))
+    gdbus_codegen = find_program('gdbus-codegen', required: false)
     gio_unix = dependency('gio-unix-2.0', required: get_option('gio'),
                           method: 'pkg-config')
     gio = declare_dependency(dependencies: [gio, gio_unix],
-- 
2.51.0

Re: [PATCH] make gdbus-codegen optional, not required by passt

Posted by Marc-André Lureau 2 weeks, 4 days ago

On Mon, Oct 27, 2025 at 4:59 PM Nicolas PARLANT
<nicolas.parlant@parhuet.fr> wrote:
>
> passt needs gio but not gdbus-codegen. Make gdbus-codegen optional,
> dbus_display which requires it will still fail as expected.
>
> Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  meson.build | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index c5710a6a47..3f7c973127 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1126,8 +1126,7 @@ if not get_option('gio').auto() or have_system
>      gio = not_found
>    endif
>    if gio.found()
> -    gdbus_codegen = find_program('gdbus-codegen',
> -                                 required: get_option('gio'))
> +    gdbus_codegen = find_program('gdbus-codegen', required: false)
>      gio_unix = dependency('gio-unix-2.0', required: get_option('gio'),
>                            method: 'pkg-config')
>      gio = declare_dependency(dependencies: [gio, gio_unix],
> --
> 2.51.0
>
>


-- 
Marc-André Lureau