tests/functional/riscv64/test_sifive_u: Remove unused import statement

[PATCH] tests/functional/riscv64/test_sifive_u: Remove unused import statement

Posted by Thomas Huth 2 weeks, 4 days ago

From: Thomas Huth <thuth@redhat.com>

skipIfMissingCommands is not used here, remove the import to silence
a pylint warning for this file.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/riscv64/test_sifive_u.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/functional/riscv64/test_sifive_u.py b/tests/functional/riscv64/test_sifive_u.py
index 358ff0d1f60..847f709da12 100755
--- a/tests/functional/riscv64/test_sifive_u.py
+++ b/tests/functional/riscv64/test_sifive_u.py
@@ -13,7 +13,6 @@
 import os
 
 from qemu_test import Asset, LinuxKernelTest
-from qemu_test import skipIfMissingCommands
 
 
 class SifiveU(LinuxKernelTest):
-- 
2.51.0

Re: [PATCH] tests/functional/riscv64/test_sifive_u: Remove unused import statement

Posted by Alistair Francis 2 weeks, 1 day ago

On Mon, Oct 27, 2025 at 9:29 PM Thomas Huth <thuth@redhat.com> wrote:
>
> From: Thomas Huth <thuth@redhat.com>
>
> skipIfMissingCommands is not used here, remove the import to silence
> a pylint warning for this file.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>  tests/functional/riscv64/test_sifive_u.py | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tests/functional/riscv64/test_sifive_u.py b/tests/functional/riscv64/test_sifive_u.py
> index 358ff0d1f60..847f709da12 100755
> --- a/tests/functional/riscv64/test_sifive_u.py
> +++ b/tests/functional/riscv64/test_sifive_u.py
> @@ -13,7 +13,6 @@
>  import os
>
>  from qemu_test import Asset, LinuxKernelTest
> -from qemu_test import skipIfMissingCommands
>
>
>  class SifiveU(LinuxKernelTest):
> --
> 2.51.0
>
>

Re: [PATCH] tests/functional/riscv64/test_sifive_u: Remove unused import statement

Posted by Alistair Francis 2 weeks, 1 day ago

On Mon, Oct 27, 2025 at 9:29 PM Thomas Huth <thuth@redhat.com> wrote:
>
> From: Thomas Huth <thuth@redhat.com>
>
> skipIfMissingCommands is not used here, remove the import to silence
> a pylint warning for this file.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  tests/functional/riscv64/test_sifive_u.py | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tests/functional/riscv64/test_sifive_u.py b/tests/functional/riscv64/test_sifive_u.py
> index 358ff0d1f60..847f709da12 100755
> --- a/tests/functional/riscv64/test_sifive_u.py
> +++ b/tests/functional/riscv64/test_sifive_u.py
> @@ -13,7 +13,6 @@
>  import os
>
>  from qemu_test import Asset, LinuxKernelTest
> -from qemu_test import skipIfMissingCommands
>
>
>  class SifiveU(LinuxKernelTest):
> --
> 2.51.0
>
>

Re: [PATCH] tests/functional/riscv64/test_sifive_u: Remove unused import statement

Posted by Nutty.Liu 2 weeks, 3 days ago

On 10/27/2025 7:28 PM, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> skipIfMissingCommands is not used here, remove the import to silence
> a pylint warning for this file.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/functional/riscv64/test_sifive_u.py | 1 -
>   1 file changed, 1 deletion(-)
Reviewed-by: Nutty Liu <nutty.liu@hotmail.com>

Thanks,
Nutty

Re: [PATCH] tests/functional/riscv64/test_sifive_u: Remove unused import statement

Posted by Daniel Henrique Barboza 2 weeks, 4 days ago


On 10/27/25 8:28 AM, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> skipIfMissingCommands is not used here, remove the import to silence
> a pylint warning for this file.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

>   tests/functional/riscv64/test_sifive_u.py | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tests/functional/riscv64/test_sifive_u.py b/tests/functional/riscv64/test_sifive_u.py
> index 358ff0d1f60..847f709da12 100755
> --- a/tests/functional/riscv64/test_sifive_u.py
> +++ b/tests/functional/riscv64/test_sifive_u.py
> @@ -13,7 +13,6 @@
>   import os
>   
>   from qemu_test import Asset, LinuxKernelTest
> -from qemu_test import skipIfMissingCommands
>   
>   
>   class SifiveU(LinuxKernelTest):

Re: [PATCH] tests/functional/riscv64/test_sifive_u: Remove unused import statement

Posted by Philippe Mathieu-Daudé 2 weeks, 4 days ago

On 27/10/25 12:28, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> skipIfMissingCommands is not used here, remove the import to silence
> a pylint warning for this file.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/functional/riscv64/test_sifive_u.py | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>