migration: Cleanup around MigMode sets

[PATCH 0/3] migration: Cleanup around MigMode sets

Markus Armbruster posted 3 patches 2 weeks, 4 days ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251027064503.1074255-1-armbru@redhat.com

Maintainers: Alex Williamson <alex@shazbot.org>, "Cédric Le Goater" <clg@redhat.com>, Steve Sistare <steven.sistare@oracle.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, Paolo Bonzini <pbonzini@redhat.com>, David Hildenbrand <david@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>

include/migration/blocker.h |  9 ++----
include/migration/misc.h    | 10 +++----
hw/vfio/container-legacy.c  |  6 ++--
hw/vfio/cpr-iommufd.c       |  6 ++--
hw/vfio/cpr-legacy.c        |  8 +++---
hw/vfio/cpr.c               |  5 ++--
hw/vfio/device.c            |  4 +--
migration/migration.c       | 57 +++++++++----------------------------
stubs/migr-blocker.c        |  2 +-
system/physmem.c            |  8 +++---
10 files changed, 40 insertions(+), 75 deletions(-)

Expand all Fold all

[PATCH 0/3] migration: Cleanup around MigMode sets

Posted by Markus Armbruster 2 weeks, 4 days ago

Markus Armbruster (3):
  migration: Use unsigned instead of int for bit set of MigMode
  migration: Use bitset of MigMode instead of variable arguments
  migration: Put Error **errp parameter last

 include/migration/blocker.h |  9 ++----
 include/migration/misc.h    | 10 +++----
 hw/vfio/container-legacy.c  |  6 ++--
 hw/vfio/cpr-iommufd.c       |  6 ++--
 hw/vfio/cpr-legacy.c        |  8 +++---
 hw/vfio/cpr.c               |  5 ++--
 hw/vfio/device.c            |  4 +--
 migration/migration.c       | 57 +++++++++----------------------------
 stubs/migr-blocker.c        |  2 +-
 system/physmem.c            |  8 +++---
 10 files changed, 40 insertions(+), 75 deletions(-)

-- 
2.49.0

Re: [PATCH 0/3] migration: Cleanup around MigMode sets

Posted by Fabiano Rosas 2 weeks, 4 days ago

Markus Armbruster <armbru@redhat.com> writes:

> Markus Armbruster (3):
>   migration: Use unsigned instead of int for bit set of MigMode
>   migration: Use bitset of MigMode instead of variable arguments
>   migration: Put Error **errp parameter last
>
>  include/migration/blocker.h |  9 ++----
>  include/migration/misc.h    | 10 +++----
>  hw/vfio/container-legacy.c  |  6 ++--
>  hw/vfio/cpr-iommufd.c       |  6 ++--
>  hw/vfio/cpr-legacy.c        |  8 +++---
>  hw/vfio/cpr.c               |  5 ++--
>  hw/vfio/device.c            |  4 +--
>  migration/migration.c       | 57 +++++++++----------------------------
>  stubs/migr-blocker.c        |  2 +-
>  system/physmem.c            |  8 +++---
>  10 files changed, 40 insertions(+), 75 deletions(-)

Series:

Reviewed-by: Fabiano Rosas <farosas@suse.de>

Re: [PATCH 0/3] migration: Cleanup around MigMode sets

Posted by Peter Xu 2 weeks, 3 days ago

On Mon, Oct 27, 2025 at 10:24:47AM -0300, Fabiano Rosas wrote:
> Markus Armbruster <armbru@redhat.com> writes:
> 
> > Markus Armbruster (3):
> >   migration: Use unsigned instead of int for bit set of MigMode
> >   migration: Use bitset of MigMode instead of variable arguments
> >   migration: Put Error **errp parameter last
> >
> >  include/migration/blocker.h |  9 ++----
> >  include/migration/misc.h    | 10 +++----
> >  hw/vfio/container-legacy.c  |  6 ++--
> >  hw/vfio/cpr-iommufd.c       |  6 ++--
> >  hw/vfio/cpr-legacy.c        |  8 +++---
> >  hw/vfio/cpr.c               |  5 ++--
> >  hw/vfio/device.c            |  4 +--
> >  migration/migration.c       | 57 +++++++++----------------------------
> >  stubs/migr-blocker.c        |  2 +-
> >  system/physmem.c            |  8 +++---
> >  10 files changed, 40 insertions(+), 75 deletions(-)
> 
> Series:
> 
> Reviewed-by: Fabiano Rosas <farosas@suse.de>

I recall I tried to convince Steve to use a bitmask like what patch2 does
but failed.. I didn't push that too hard, though.

Queued, thanks both!

-- 
Peter Xu