On Sun, 26 Oct 2025 at 10:53, <fanyihao@rt-thread.org> wrote:
>
> From: Yihao Fan <fanyihao@rt-thread.org>
>
> This patch series introduces basic support for the STM32F407 SoC and
> a new STM32F4spark machine in QEMU, along with a PWR device model.
>
> In addition, I have modified the header file referenced by the RCC
> driver to STM32RCC in accordance with the suggestions.
>
> This series includes:
> - A new SoC model (STM32F407) with initial integration.
> - A board model called STM32F4spark to instantiate and test the SoC.
> - A PWR device implementation for STM32F4xx family.
>
> Signed-off-by: Yihao Fan <fanyihao@rt-thread.org>
> ---
>
> Yihao Fan (3):
> hw/arm: Add support for the STM32F407 SoC
> hw/arm: Add support for the STM32F407-RT-SPARk board
> hw/arm/stm32f407: Add PWR device to stm32f407 SoC
>
> MAINTAINERS | 14 ++
> docs/system/arm/STM32F407-RT-SPARK.rst | 41 +++++
> docs/system/arm/stm32.rst | 2 +
> docs/system/target-arm.rst | 1 +
> hw/arm/Kconfig | 13 ++
> hw/arm/meson.build | 2 +
> hw/arm/stm32f407_soc.c | 217 +++++++++++++++++++++++++
> hw/arm/stm32f4spark.c | 56 +++++++
> hw/misc/Kconfig | 3 +
> hw/misc/meson.build | 1 +
> hw/misc/stm32f4xx_pwr.c | 111 +++++++++++++
> include/hw/arm/stm32f407_soc.h | 77 +++++++++
> include/hw/misc/stm32f4xx_pwr.h | 40 +++++
> 13 files changed, 578 insertions(+)
> create mode 100644 docs/system/arm/STM32F407-RT-SPARK.rst
> create mode 100644 hw/arm/stm32f407_soc.c
> create mode 100644 hw/arm/stm32f4spark.c
> create mode 100644 hw/misc/stm32f4xx_pwr.c
> create mode 100644 include/hw/arm/stm32f407_soc.h
> create mode 100644 include/hw/misc/stm32f4xx_pwr.h
Thanks for sending this; I have some review comments,
but they're mostly fairly minor.
Please can you include a functional test under
tests/functional/arm/ which runs the new board model
with some kind of guest image to check that it can
successfully run code ?
thanks
-- PMM