ppc/amigaone: Free allocated struct

[PATCH] ppc/amigaone: Free allocated struct

BALATON Zoltan posted 1 patch 3 weeks, 1 day ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251022211649.9A09E5972E5@zero.eik.bme.hu

Maintainers: BALATON Zoltan <balaton@eik.bme.hu>

hw/ppc/amigaone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] ppc/amigaone: Free allocated struct

Posted by BALATON Zoltan 3 weeks, 1 day ago

In create_bd_info function a bd_info struct is allocated but never
freed. Mark it g_autofree to avoid leaking it.

Fixes: 34f053d86b (ppc/amigaone: Add kernel and initrd support)
Resolves: Coverity CID 1641398
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/ppc/amigaone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c
index 12279f42bc..47fb016b4a 100644
--- a/hw/ppc/amigaone.c
+++ b/hw/ppc/amigaone.c
@@ -221,7 +221,7 @@ struct bd_info {
 
 static void create_bd_info(hwaddr addr, ram_addr_t ram_size)
 {
-    struct bd_info *bd = g_new0(struct bd_info, 1);
+    g_autofree struct bd_info *bd = g_new0(struct bd_info, 1);
 
     bd->bi_memsize =    cpu_to_be32(ram_size);
     bd->bi_flashstart = cpu_to_be32(PROM_ADDR);
-- 
2.41.3

Re: [PATCH] ppc/amigaone: Free allocated struct

Posted by Harsh Prateek Bora 3 weeks, 1 day ago


On 10/23/25 02:37, BALATON Zoltan wrote:
> In create_bd_info function a bd_info struct is allocated but never
> freed. Mark it g_autofree to avoid leaking it.
> 
> Fixes: 34f053d86b (ppc/amigaone: Add kernel and initrd support)
> Resolves: Coverity CID 1641398
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/ppc/amigaone.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c
> index 12279f42bc..47fb016b4a 100644
> --- a/hw/ppc/amigaone.c
> +++ b/hw/ppc/amigaone.c
> @@ -221,7 +221,7 @@ struct bd_info {
>   
>   static void create_bd_info(hwaddr addr, ram_addr_t ram_size)
>   {
> -    struct bd_info *bd = g_new0(struct bd_info, 1);
> +    g_autofree struct bd_info *bd = g_new0(struct bd_info, 1);
>   

Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

>       bd->bi_memsize =    cpu_to_be32(ram_size);
>       bd->bi_flashstart = cpu_to_be32(PROM_ADDR);