[PATCH v4 2/5] igvm: fix off by one bug in memmap entry count checking

Gerd Hoffmann posted 5 patches 3 weeks, 2 days ago
Maintainers: Roy Hopkins <roy.hopkins@randomman.co.uk>, Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <anisinha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Zhao Liu <zhao1.liu@intel.com>
There is a newer version of this series
[PATCH v4 2/5] igvm: fix off by one bug in memmap entry count checking
Posted by Gerd Hoffmann 3 weeks, 2 days ago
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 backends/igvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backends/igvm.c b/backends/igvm.c
index 723d45b755a0..055bbba745ad 100644
--- a/backends/igvm.c
+++ b/backends/igvm.c
@@ -567,7 +567,7 @@ static int qigvm_directive_memory_map(QIgvm *ctx, const uint8_t *header_data,
 
             retval = ctx->cgsc->get_mem_map_entry(entry, &cgmm_entry, errp);
             while (retval == 0) {
-                if (entry > max_entry_count) {
+                if (entry >= max_entry_count) {
                     error_setg(
                         errp,
                         "IGVM: guest memory map size exceeds parameter area defined in IGVM file");
-- 
2.51.0
Re: [PATCH v4 2/5] igvm: fix off by one bug in memmap entry count checking
Posted by Stefano Garzarella 3 weeks, 2 days ago
On Wed, Oct 22, 2025 at 10:44:36AM +0200, Gerd Hoffmann wrote:

Should we CC stable and add fixes tag?

Fixes: c1d466d267 ("backends/igvm: Add IGVM loader and configuration")

>Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>---
> backends/igvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for fixing it!

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/backends/igvm.c b/backends/igvm.c
>index 723d45b755a0..055bbba745ad 100644
>--- a/backends/igvm.c
>+++ b/backends/igvm.c
>@@ -567,7 +567,7 @@ static int qigvm_directive_memory_map(QIgvm *ctx, const uint8_t *header_data,
>
>             retval = ctx->cgsc->get_mem_map_entry(entry, &cgmm_entry, errp);
>             while (retval == 0) {
>-                if (entry > max_entry_count) {
>+                if (entry >= max_entry_count) {
>                     error_setg(
>                         errp,
>                         "IGVM: guest memory map size exceeds parameter area defined in IGVM file");
>-- 
>2.51.0
>
Re: [PATCH v4 2/5] igvm: fix off by one bug in memmap entry count checking
Posted by Luigi Leonardi 3 weeks, 2 days ago
On Wed, Oct 22, 2025 at 10:44:36AM +0200, Gerd Hoffmann wrote:
>Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>---
> backends/igvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/backends/igvm.c b/backends/igvm.c
>index 723d45b755a0..055bbba745ad 100644
>--- a/backends/igvm.c
>+++ b/backends/igvm.c
>@@ -567,7 +567,7 @@ static int qigvm_directive_memory_map(QIgvm *ctx, const uint8_t *header_data,
>
>             retval = ctx->cgsc->get_mem_map_entry(entry, &cgmm_entry, errp);
>             while (retval == 0) {
>-                if (entry > max_entry_count) {
>+                if (entry >= max_entry_count) {
>                     error_setg(
>                         errp,
>                         "IGVM: guest memory map size exceeds parameter area defined in IGVM file");
>-- 2.51.0
>

LGTM!

Reviewed-by: Luigi Leonardi <leonardi@redhat.com>