hw/arm/aspeed: Remove ast2700fc self-aliasing

[PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing

Philippe Mathieu-Daudé posted 1 patch 3 months, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251021110427.93991-1-philmd@linaro.org

Maintainers: "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>

hw/arm/aspeed_ast27x0-fc.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing

Posted by Philippe Mathieu-Daudé 3 months, 2 weeks ago

Remove pointless alias to the very same machine:

  $ qemu-system-aarch64 -M help | fgrep ast2700fc
  ast2700fc            ast2700 full core support (alias of ast2700fc)
  ast2700fc            ast2700 full core support

Fixes: a74faf35efc ("hw/arm: Introduce ASPEED AST2700 A1 full core machine")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/arm/aspeed_ast27x0-fc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/arm/aspeed_ast27x0-fc.c b/hw/arm/aspeed_ast27x0-fc.c
index a61ecff3909..463dd30cc5d 100644
--- a/hw/arm/aspeed_ast27x0-fc.c
+++ b/hw/arm/aspeed_ast27x0-fc.c
@@ -180,7 +180,6 @@ static void ast2700fc_class_init(ObjectClass *oc, const void *data)
 {
     MachineClass *mc = MACHINE_CLASS(oc);
 
-    mc->alias = "ast2700fc";
     mc->desc = "ast2700 full core support";
     mc->init = ast2700fc_init;
     mc->no_floppy = 1;
-- 
2.51.0

Re: [PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing

Posted by Philippe Mathieu-Daudé 3 months, 1 week ago

On 21/10/25 13:04, Philippe Mathieu-Daudé wrote:
> Remove pointless alias to the very same machine:
> 
>    $ qemu-system-aarch64 -M help | fgrep ast2700fc
>    ast2700fc            ast2700 full core support (alias of ast2700fc)
>    ast2700fc            ast2700 full core support
> 
> Fixes: a74faf35efc ("hw/arm: Introduce ASPEED AST2700 A1 full core machine")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/arm/aspeed_ast27x0-fc.c | 1 -
>   1 file changed, 1 deletion(-)

Merged as commit d7bd42a740d0e8887540d7b450d0bdb2d6ba31ea, thanks!

Re: [PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing

Posted by Cédric Le Goater 3 months, 2 weeks ago

On 10/21/25 13:04, Philippe Mathieu-Daudé wrote:
> Remove pointless alias to the very same machine:
> 
>    $ qemu-system-aarch64 -M help | fgrep ast2700fc
>    ast2700fc            ast2700 full core support (alias of ast2700fc)
>    ast2700fc            ast2700 full core support
> 
> Fixes: a74faf35efc ("hw/arm: Introduce ASPEED AST2700 A1 full core machine")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/arm/aspeed_ast27x0-fc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/hw/arm/aspeed_ast27x0-fc.c b/hw/arm/aspeed_ast27x0-fc.c
> index a61ecff3909..463dd30cc5d 100644
> --- a/hw/arm/aspeed_ast27x0-fc.c
> +++ b/hw/arm/aspeed_ast27x0-fc.c
> @@ -180,7 +180,6 @@ static void ast2700fc_class_init(ObjectClass *oc, const void *data)
>   {
>       MachineClass *mc = MACHINE_CLASS(oc);
>   
> -    mc->alias = "ast2700fc";
>       mc->desc = "ast2700 full core support";
>       mc->init = ast2700fc_init;
>       mc->no_floppy = 1;


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.