1. Patchew
  2. QEMU
  3. View series

[PATCH] qmp: Fix a typo for a USO feature

Jack Wang posted 1 patch 3 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251021053309.208957-1-jinpu.wang@ionos.com
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>
hw/virtio/virtio-qmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] qmp: Fix a typo for a USO feature
Posted by Jack Wang 3 months, 2 weeks ago 
There is a copy & paste error, USO6 should be there.

Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
 hw/virtio/virtio-qmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
index b338344c6cca..968299fda0c9 100644
--- a/hw/virtio/virtio-qmp.c
+++ b/hw/virtio/virtio-qmp.c
@@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
     FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
             "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
     FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
-            "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
+            "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
     FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
             "VIRTIO_NET_F_HOST_USO: Device can receive USO"),
     FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
-- 
2.43.0
Re: [PATCH] qmp: Fix a typo for a USO feature
Posted by Michael Tokarev 2 months, 3 weeks ago 
On 10/21/25 08:33, Jack Wang wrote:
> There is a copy & paste error, USO6 should be there.
> 
> Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>

It looks like this patch has been forgotten.
I can push it through the trivial-patches queue
if you like.

Thanks,

/mjt
> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
> index b338344c6cca..968299fda0c9 100644
> --- a/hw/virtio/virtio-qmp.c
> +++ b/hw/virtio/virtio-qmp.c
> @@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
>       FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
>               "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
>       FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
> -            "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
> +            "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
>       FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
>               "VIRTIO_NET_F_HOST_USO: Device can receive USO"),
>       FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
Re: [PATCH] qmp: Fix a typo for a USO feature
Posted by Jinpu Wang 2 months, 3 weeks ago 
On Mon, Nov 17, 2025 at 9:38 AM Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> On 10/21/25 08:33, Jack Wang wrote:
> > There is a copy & paste error, USO6 should be there.
> >
> > Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
> > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
>
> It looks like this patch has been forgotten.
> I can push it through the trivial-patches queue
> if you like.
>
> Thanks,
>
Hi Michael,

Yes, that sounds excellent. Please go ahead and push it through the
trivial-patches queue.

I agree the typo should be fixed regardless; I haven't had time to
look into the FEATURE_ENTRY macros in detail yet.

Thanks,
Jinpu
> /mjt
> > diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
> > index b338344c6cca..968299fda0c9 100644
> > --- a/hw/virtio/virtio-qmp.c
> > +++ b/hw/virtio/virtio-qmp.c
> > @@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
> >       FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
> >               "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
> >       FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
> > -            "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
> > +            "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
> >       FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
> >               "VIRTIO_NET_F_HOST_USO: Device can receive USO"),
> >       FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
>
Re: [PATCH] qmp: Fix a typo for a USO feature
Posted by Michael S. Tsirkin 3 months, 2 weeks ago 
On Tue, Oct 21, 2025 at 07:33:09AM +0200, Jack Wang wrote:
> There is a copy & paste error, USO6 should be there.
> 
> Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>

Can the FEATURE_ENTRY macro be updated to include the
string in there automatically, please?
It's really pointless to repeat it.


> ---
>  hw/virtio/virtio-qmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
> index b338344c6cca..968299fda0c9 100644
> --- a/hw/virtio/virtio-qmp.c
> +++ b/hw/virtio/virtio-qmp.c
> @@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
>      FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
>              "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
>      FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
> -            "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
> +            "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
>      FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
>              "VIRTIO_NET_F_HOST_USO: Device can receive USO"),
>      FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
> -- 
> 2.43.0

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.