[PATCH] qmp: Fix a typo for a USO feature

Jack Wang posted 1 patch 3 weeks, 3 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251021053309.208957-1-jinpu.wang@ionos.com
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>
hw/virtio/virtio-qmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] qmp: Fix a typo for a USO feature
Posted by Jack Wang 3 weeks, 3 days ago
There is a copy & paste error, USO6 should be there.

Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
 hw/virtio/virtio-qmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
index b338344c6cca..968299fda0c9 100644
--- a/hw/virtio/virtio-qmp.c
+++ b/hw/virtio/virtio-qmp.c
@@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
     FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
             "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
     FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
-            "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
+            "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
     FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
             "VIRTIO_NET_F_HOST_USO: Device can receive USO"),
     FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
-- 
2.43.0
Re: [PATCH] qmp: Fix a typo for a USO feature
Posted by Michael S. Tsirkin 3 weeks, 3 days ago
On Tue, Oct 21, 2025 at 07:33:09AM +0200, Jack Wang wrote:
> There is a copy & paste error, USO6 should be there.
> 
> Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>

Can the FEATURE_ENTRY macro be updated to include the
string in there automatically, please?
It's really pointless to repeat it.


> ---
>  hw/virtio/virtio-qmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
> index b338344c6cca..968299fda0c9 100644
> --- a/hw/virtio/virtio-qmp.c
> +++ b/hw/virtio/virtio-qmp.c
> @@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
>      FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
>              "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
>      FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
> -            "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
> +            "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
>      FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
>              "VIRTIO_NET_F_HOST_USO: Device can receive USO"),
>      FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
> -- 
> 2.43.0