[PATCH v2 4/4] hw/arm/virt: Remove VirtMachineClass::kvm_no_adjvtime field

Philippe Mathieu-Daudé posted 4 patches 3 weeks, 4 days ago
Maintainers: Peter Maydell <peter.maydell@linaro.org>
[PATCH v2 4/4] hw/arm/virt: Remove VirtMachineClass::kvm_no_adjvtime field
Posted by Philippe Mathieu-Daudé 3 weeks, 4 days ago
The VirtMachineClass::kvm_no_adjvtime field was only used by the
virt-4.2 machine, which got removed. Remove it as now unused, but
keep the ARMCPU homonym property.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/hw/arm/virt.h | 1 -
 hw/arm/virt.c         | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index 993872bb680..c77a33f6df2 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -123,7 +123,6 @@ struct VirtMachineClass {
     MachineClass parent;
     bool no_tcg_its;
     bool no_highmem_compact;
-    bool kvm_no_adjvtime;
     bool no_kvm_steal_time;
     bool acpi_expose_flash;
     bool no_secure_gpio;
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index b781a218019..ffbddb711f6 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2362,11 +2362,6 @@ static void machvirt_init(MachineState *machine)
             object_property_set_bool(cpuobj, "has_el2", false, NULL);
         }
 
-        if (vmc->kvm_no_adjvtime &&
-            object_property_find(cpuobj, "kvm-no-adjvtime")) {
-            object_property_set_bool(cpuobj, "kvm-no-adjvtime", true, NULL);
-        }
-
         if (vmc->no_kvm_steal_time &&
             object_property_find(cpuobj, "kvm-steal-time")) {
             object_property_set_bool(cpuobj, "kvm-steal-time", false, NULL);
-- 
2.51.0


Re: [PATCH v2 4/4] hw/arm/virt: Remove VirtMachineClass::kvm_no_adjvtime field
Posted by Peter Maydell 2 weeks, 3 days ago
On Mon, 20 Oct 2025 at 10:40, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> The VirtMachineClass::kvm_no_adjvtime field was only used by the
> virt-4.2 machine, which got removed. Remove it as now unused, but
> keep the ARMCPU homonym property.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  include/hw/arm/virt.h | 1 -
>  hw/arm/virt.c         | 5 -----
>  2 files changed, 6 deletions(-)
>
> diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
> index 993872bb680..c77a33f6df2 100644
> --- a/include/hw/arm/virt.h
> +++ b/include/hw/arm/virt.h
> @@ -123,7 +123,6 @@ struct VirtMachineClass {
>      MachineClass parent;
>      bool no_tcg_its;
>      bool no_highmem_compact;
> -    bool kvm_no_adjvtime;
>      bool no_kvm_steal_time;
>      bool acpi_expose_flash;
>      bool no_secure_gpio;
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index b781a218019..ffbddb711f6 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -2362,11 +2362,6 @@ static void machvirt_init(MachineState *machine)
>              object_property_set_bool(cpuobj, "has_el2", false, NULL);
>          }
>
> -        if (vmc->kvm_no_adjvtime &&
> -            object_property_find(cpuobj, "kvm-no-adjvtime")) {
> -            object_property_set_bool(cpuobj, "kvm-no-adjvtime", true, NULL);
> -        }
> -
>          if (vmc->no_kvm_steal_time &&
>              object_property_find(cpuobj, "kvm-steal-time")) {
>              object_property_set_bool(cpuobj, "kvm-steal-time", false, NULL);

Can we / should we start the deprecate-and-drop process
for the CPU kvm-no-adjvtime property now ?

-- PMM