1. Patchew
  2. QEMU
  3. View series

[PATCH 00/12] hw/s390x: Remove s390-ccw-virtio-4.2 -> s390-ccw-virtio-7.2 machines

Philippe Mathieu-Daudé posted 12 patches 4 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251017133002.61410-1-philmd@linaro.org
Maintainers: Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Jason Herne <jjherne@linux.ibm.com>
include/hw/s390x/s390-virtio-ccw.h |   3 -
include/hw/s390x/sclp.h            |   5 +-
hw/s390x/s390-virtio-ccw.c         | 175 +----------------------------
hw/s390x/sclp.c                    |  34 +-----
4 files changed, 6 insertions(+), 211 deletions(-)
[PATCH 00/12] hw/s390x: Remove s390-ccw-virtio-4.2 -> s390-ccw-virtio-7.2 machines
Posted by Philippe Mathieu-Daudé 4 weeks ago 
Remove the deprecated s390-ccw-virtio-4.2 up to 7.2 machines,
which are older than 6 years. Remove resulting dead code.

Philippe Mathieu-Daudé (12):
  hw/s390x/ccw: Remove deprecated s390-ccw-virtio-4.2 machine
  hw/s390x/ccw: Remove SCLPDevice::increment_size field
  hw/s390x/ccw: Remove deprecated s390-ccw-virtio-5.0 machine
  hw/s390x/ccw: Remove deprecated s390-ccw-virtio-5.1 machine
  hw/s390x/ccw: Remove deprecated s390-ccw-virtio-5.2 machine
  hw/s390x/ccw: Remove deprecated s390-ccw-virtio-6.0 machine
  hw/s390x/ccw: Remove deprecated s390-ccw-virtio-6.1 machine
  hw/s390x/ccw: Remove deprecated s390-ccw-virtio-6.2 machine
  hw/s390x/ccw: Remove deprecated s390-ccw-virtio-7.0 machine
  hw/s390x/ccw: Remove deprecated s390-ccw-virtio-7.1 machine
  hw/s390x/ccw: Remove S390CcwMachineClass::max_threads field
  hw/s390x/ccw: Remove deprecated s390-ccw-virtio-7.2 machine

 include/hw/s390x/s390-virtio-ccw.h |   3 -
 include/hw/s390x/sclp.h            |   5 +-
 hw/s390x/s390-virtio-ccw.c         | 175 +----------------------------
 hw/s390x/sclp.c                    |  34 +-----
 4 files changed, 6 insertions(+), 211 deletions(-)

-- 
2.51.0
Re: [PATCH 00/12] hw/s390x: Remove s390-ccw-virtio-4.2 -> s390-ccw-virtio-7.2 machines
Posted by Thomas Huth 4 weeks ago 
On 17/10/2025 15.29, Philippe Mathieu-Daudé wrote:
> Remove the deprecated s390-ccw-virtio-4.2 up to 7.2 machines,
> which are older than 6 years. Remove resulting dead code.
> 
> Philippe Mathieu-Daudé (12):
>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-4.2 machine
>    hw/s390x/ccw: Remove SCLPDevice::increment_size field
>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-5.0 machine
>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-5.1 machine
>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-5.2 machine
>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-6.0 machine
>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-6.1 machine
>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-6.2 machine
>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-7.0 machine
>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-7.1 machine
>    hw/s390x/ccw: Remove S390CcwMachineClass::max_threads field
>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-7.2 machine

NACK.

Being deprecated does not mean that the deprecation period already expired.
Please re-read the paragraph about machine deprecation in 
docs/about/deprecated.rst carefully again.

  Thomas
Re: [PATCH 00/12] hw/s390x: Remove s390-ccw-virtio-4.2 -> s390-ccw-virtio-7.2 machines
Posted by Philippe Mathieu-Daudé 4 weeks ago 
On 17/10/25 15:38, Thomas Huth wrote:
> On 17/10/2025 15.29, Philippe Mathieu-Daudé wrote:
>> Remove the deprecated s390-ccw-virtio-4.2 up to 7.2 machines,
>> which are older than 6 years. Remove resulting dead code.
>>
>> Philippe Mathieu-Daudé (12):
>>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-4.2 machine
>>    hw/s390x/ccw: Remove SCLPDevice::increment_size field

> NACK.
> 
> Being deprecated does not mean that the deprecation period already expired.
> Please re-read the paragraph about machine deprecation in docs/about/ 
> deprecated.rst carefully again.

Yes, my bad, I misunderstood the '-M help' output.

Still, please consider the first 2 patches (4.2 is over 6yo).

Regards,

Phil.
Re: [PATCH 00/12] hw/s390x: Remove s390-ccw-virtio-4.2 -> s390-ccw-virtio-7.2 machines
Posted by Thomas Huth 4 weeks ago 
On 17/10/2025 15.40, Philippe Mathieu-Daudé wrote:
> On 17/10/25 15:38, Thomas Huth wrote:
>> On 17/10/2025 15.29, Philippe Mathieu-Daudé wrote:
>>> Remove the deprecated s390-ccw-virtio-4.2 up to 7.2 machines,
>>> which are older than 6 years. Remove resulting dead code.
>>>
>>> Philippe Mathieu-Daudé (12):
>>>    hw/s390x/ccw: Remove deprecated s390-ccw-virtio-4.2 machine
>>>    hw/s390x/ccw: Remove SCLPDevice::increment_size field
> 
>> NACK.
>>
>> Being deprecated does not mean that the deprecation period already expired.
>> Please re-read the paragraph about machine deprecation in docs/about/ 
>> deprecated.rst carefully again.
> 
> Yes, my bad, I misunderstood the '-M help' output.
> 
> Still, please consider the first 2 patches (4.2 is over 6yo).

Agreed, 4.2 can be removed. But in that case, please add a 3rd patch that 
also removes the fixup_ram_size stuff from hw/core/machine.c since s390x was 
the last user.

  Thanks,
   Thomas

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.