[PATCH 00/20] hw/arm/virt: Remove virt-4.1 -> virt-7.2 machines

Philippe Mathieu-Daudé posted 20 patches 3 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251017130821.58388-1-philmd@linaro.org
Maintainers: Shannon Zhao <shannon.zhaosl@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <anisinha@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
include/hw/arm/virt.h    |  11 --
hw/arm/virt-acpi-build.c |  37 +------
hw/arm/virt.c            | 228 ++++++++-------------------------------
3 files changed, 50 insertions(+), 226 deletions(-)
[PATCH 00/20] hw/arm/virt: Remove virt-4.1 -> virt-7.2 machines
Posted by Philippe Mathieu-Daudé 3 months, 3 weeks ago
Remove the deprecated virt-4.1 up to virt-7.2 machines,
which are older than 6 years. Remove resulting dead code.

Philippe Mathieu-Daudé (20):
  hw/arm/virt: Remove deprecated virt-4.1 machine
  hw/arm/virt: Remove VirtMachineClass::no_ged field
  hw/arm/virt: Remove deprecated virt-4.2 machine
  hw/arm/virt: Remove VirtMachineClass::kvm_no_adjvtime field
  hw/arm/virt: Remove deprecated virt-5.0 machine
  hw/arm/virt: Remove VirtMachineClass::acpi_expose_flash field
  hw/arm/virt: Remove deprecated virt-5.1 machine
  hw/arm/virt: Remove VirtMachineClass::no_kvm_steal_time field
  hw/arm/virt: Remove deprecated virt-5.2 machine
  hw/arm/virt: Remove VirtMachineClass::no_secure_gpio field
  hw/arm/virt: Remove deprecated virt-6.0 machine
  hw/arm/virt: Remove deprecated virt-6.1 machine
  hw/arm/virt: Remove VirtMachineClass::no_tcg_its field
  hw/arm/virt: Remove VirtMachineClass::no_cpu_topology field
  hw/arm/virt: Remove deprecated virt-6.2 machine
  hw/arm/virt: Remove VirtMachineClass::no_tcg_lpa2 field
  hw/arm/virt: Remove deprecated virt-7.0 machine
  hw/arm/virt: Remove deprecated virt-7.1 machine
  hw/arm/virt: Remove VirtMachineClass::no_highmem_compact field
  hw/arm/virt: Remove deprecated virt-7.2 machine

 include/hw/arm/virt.h    |  11 --
 hw/arm/virt-acpi-build.c |  37 +------
 hw/arm/virt.c            | 228 ++++++++-------------------------------
 3 files changed, 50 insertions(+), 226 deletions(-)

-- 
2.51.0


Re: [PATCH 00/20] hw/arm/virt: Remove virt-4.1 -> virt-7.2 machines
Posted by Daniel P. Berrangé 3 months, 3 weeks ago
On Fri, Oct 17, 2025 at 03:07:59PM +0200, Philippe Mathieu-Daudé wrote:
> Remove the deprecated virt-4.1 up to virt-7.2 machines,
> which are older than 6 years. Remove resulting dead code.

Nope, that's too aggressive here too. Only the 4.1/4.2 machines
can be removed. The others are all still reported as being valid
machines with '-machine help' - they'll be automatically removed
from that list once their expiry release cycle is started.

> 
> Philippe Mathieu-Daudé (20):
>   hw/arm/virt: Remove deprecated virt-4.1 machine
>   hw/arm/virt: Remove VirtMachineClass::no_ged field
>   hw/arm/virt: Remove deprecated virt-4.2 machine
>   hw/arm/virt: Remove VirtMachineClass::kvm_no_adjvtime field
>   hw/arm/virt: Remove deprecated virt-5.0 machine
>   hw/arm/virt: Remove VirtMachineClass::acpi_expose_flash field
>   hw/arm/virt: Remove deprecated virt-5.1 machine
>   hw/arm/virt: Remove VirtMachineClass::no_kvm_steal_time field
>   hw/arm/virt: Remove deprecated virt-5.2 machine
>   hw/arm/virt: Remove VirtMachineClass::no_secure_gpio field
>   hw/arm/virt: Remove deprecated virt-6.0 machine
>   hw/arm/virt: Remove deprecated virt-6.1 machine
>   hw/arm/virt: Remove VirtMachineClass::no_tcg_its field
>   hw/arm/virt: Remove VirtMachineClass::no_cpu_topology field
>   hw/arm/virt: Remove deprecated virt-6.2 machine
>   hw/arm/virt: Remove VirtMachineClass::no_tcg_lpa2 field
>   hw/arm/virt: Remove deprecated virt-7.0 machine
>   hw/arm/virt: Remove deprecated virt-7.1 machine
>   hw/arm/virt: Remove VirtMachineClass::no_highmem_compact field
>   hw/arm/virt: Remove deprecated virt-7.2 machine
> 
>  include/hw/arm/virt.h    |  11 --
>  hw/arm/virt-acpi-build.c |  37 +------
>  hw/arm/virt.c            | 228 ++++++++-------------------------------
>  3 files changed, 50 insertions(+), 226 deletions(-)
> 
> -- 
> 2.51.0
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PATCH 00/20] hw/arm/virt: Remove virt-4.1 -> virt-7.2 machines
Posted by Philippe Mathieu-Daudé 3 months, 3 weeks ago
On 17/10/25 15:18, Daniel P. Berrangé wrote:
> On Fri, Oct 17, 2025 at 03:07:59PM +0200, Philippe Mathieu-Daudé wrote:
>> Remove the deprecated virt-4.1 up to virt-7.2 machines,
>> which are older than 6 years. Remove resulting dead code.
> 
> Nope, that's too aggressive here too. Only the 4.1/4.2 machines
> can be removed. The others are all still reported as being valid
> machines with '-machine help' - they'll be automatically removed
> from that list once their expiry release cycle is started.

Right :/

>>
>> Philippe Mathieu-Daudé (20):
>>    hw/arm/virt: Remove deprecated virt-4.1 machine
>>    hw/arm/virt: Remove VirtMachineClass::no_ged field
>>    hw/arm/virt: Remove deprecated virt-4.2 machine
>>    hw/arm/virt: Remove VirtMachineClass::kvm_no_adjvtime field

So please only consider these 4 patches to review then.

Thanks,

Phil.