Move AST1030 machine to a separate file

[PATCH v1 0/1] Move AST1030 machine to a separate file

Jamin Lin via posted 1 patch 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251015081219.2766143-1-jamin._5Flin@aspeedtech.com

Maintainers: "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>

include/hw/arm/aspeed.h        |  18 ++++++
hw/arm/aspeed.c                | 106 ++------------------------------
hw/arm/aspeed_ast10x0_boards.c | 107 +++++++++++++++++++++++++++++++++
hw/arm/meson.build             |   1 +
4 files changed, 130 insertions(+), 102 deletions(-)
create mode 100644 hw/arm/aspeed_ast10x0_boards.c

Expand all Fold all

[PATCH v1 0/1] Move AST1030 machine to a separate file

Posted by Jamin Lin via 1 month ago

v1:
 1. Move AST1030 machine to a separate file

Jamin Lin (1):
  hw/arm/aspeed: Move AST1030 machine to a separate file

 include/hw/arm/aspeed.h        |  18 ++++++
 hw/arm/aspeed.c                | 106 ++------------------------------
 hw/arm/aspeed_ast10x0_boards.c | 107 +++++++++++++++++++++++++++++++++
 hw/arm/meson.build             |   1 +
 4 files changed, 130 insertions(+), 102 deletions(-)
 create mode 100644 hw/arm/aspeed_ast10x0_boards.c

-- 
2.43.0

Re: [SPAM] [PATCH v1 0/1] Move AST1030 machine to a separate file

Posted by Cédric Le Goater 4 weeks ago

Jamin,

On 10/15/25 10:12, Jamin Lin wrote:
> v1:
>   1. Move AST1030 machine to a separate file
> 
> Jamin Lin (1):
>    hw/arm/aspeed: Move AST1030 machine to a separate file
> 
>   include/hw/arm/aspeed.h        |  18 ++++++
>   hw/arm/aspeed.c                | 106 ++------------------------------
>   hw/arm/aspeed_ast10x0_boards.c | 107 +++++++++++++++++++++++++++++++++
>   hw/arm/meson.build             |   1 +
>   4 files changed, 130 insertions(+), 102 deletions(-)
>   create mode 100644 hw/arm/aspeed_ast10x0_boards.c
> 

I will wait for your proposal reorganizing the aspeed machine files.


Thanks,

C.

RE: [SPAM] [PATCH v1 0/1] Move AST1030 machine to a separate file

Posted by Jamin Lin 4 weeks ago

Hi Cédric

> Subject: Re: [SPAM] [PATCH v1 0/1] Move AST1030 machine to a separate file
> 
> Jamin,
> 
> On 10/15/25 10:12, Jamin Lin wrote:
> > v1:
> >   1. Move AST1030 machine to a separate file
> >
> > Jamin Lin (1):
> >    hw/arm/aspeed: Move AST1030 machine to a separate file
> >
> >   include/hw/arm/aspeed.h        |  18 ++++++
> >   hw/arm/aspeed.c                | 106 ++------------------------------
> >   hw/arm/aspeed_ast10x0_boards.c | 107
> +++++++++++++++++++++++++++++++++
> >   hw/arm/meson.build             |   1 +
> >   4 files changed, 130 insertions(+), 102 deletions(-)
> >   create mode 100644 hw/arm/aspeed_ast10x0_boards.c
> >
> 
> I will wait for your proposal reorganizing the aspeed machine files.
> 

Thank you for your comments.
I will provide an update later in another email. It appears that this patch can be dropped, as we intend to have one C file and one commit per board/machine.

Thanks,
Jamin

> 
> Thanks,
> 
> C.
>

Re: [SPAM] [PATCH v1 0/1] Move AST1030 machine to a separate file

Posted by Cédric Le Goater 4 weeks ago

Peter,

> I will provide an update later in another email. It appears that
> this patch can be dropped, as we intend to have one C file and one
> commit per board/machine.

Do you have any opinion on this approach ?

Thanks,

C.