[PATCH v3 25/34] target/riscv: Fix size of irq_overflow_left

Anton Johansson via posted 34 patches 1 day, 5 hours ago
Maintainers: Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Laurent Vivier <laurent@vivier.eu>, Christoph Muellner <christoph.muellner@vrull.eu>
[PATCH v3 25/34] target/riscv: Fix size of irq_overflow_left
Posted by Anton Johansson via 1 day, 5 hours ago
Fix to 64 bits to hold all relevant values.

Signed-off-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 target/riscv/cpu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index c192359e56..cb99314679 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -223,7 +223,7 @@ typedef struct PMUCTRState {
     /* Snapshot value of a counter */
     uint64_t mhpmcounter_prev;
     /* Value beyond UINT32_MAX/UINT64_MAX before overflow interrupt trigger */
-    target_ulong irq_overflow_left;
+    uint64_t irq_overflow_left;
 } PMUCTRState;
 
 typedef struct PMUFixedCtrState {
-- 
2.51.0
Re: [PATCH v3 25/34] target/riscv: Fix size of irq_overflow_left
Posted by Philippe Mathieu-Daudé 5 hours ago
On 14/10/25 22:35, Anton Johansson wrote:
> Fix to 64 bits to hold all relevant values.
> 
> Signed-off-by: Anton Johansson <anjo@rev.ng>
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   target/riscv/cpu.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> index c192359e56..cb99314679 100644
> --- a/target/riscv/cpu.h
> +++ b/target/riscv/cpu.h
> @@ -223,7 +223,7 @@ typedef struct PMUCTRState {
>       /* Snapshot value of a counter */
>       uint64_t mhpmcounter_prev;
>       /* Value beyond UINT32_MAX/UINT64_MAX before overflow interrupt trigger */
> -    target_ulong irq_overflow_left;
> +    uint64_t irq_overflow_left;
>   } PMUCTRState;

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>