[v1] target/s390x: Fix missing clock-comparator interrupts

[PATCH 0/3] target/s390x: Fix missing clock-comparator interrupts

Ilya Leoshkevich posted 3 patches 1 month ago

Diff against v2 v3 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251014160743.398093-1-iii@linux.ibm.com

Maintainers: Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>

There is a newer version of this series

hw/s390x/s390-virtio-ccw.c              |  6 +--
target/s390x/cpu.c                      |  8 ++++
target/s390x/tcg/misc_helper.c          | 12 ++++--
tests/tcg/s390x/Makefile.softmmu-target |  1 +
tests/tcg/s390x/sckc.S                  | 53 +++++++++++++++++++++++++
5 files changed, 73 insertions(+), 7 deletions(-)
create mode 100644 tests/tcg/s390x/sckc.S

Expand all Fold all

[PATCH 0/3] target/s390x: Fix missing clock-comparator interrupts

Posted by Ilya Leoshkevich 1 month ago

Hi,

While trying to (so far unsuccessfully) reproduce [1], I found two bugs
in the clock comparator handling. This series fixes both and adds a
test.

[1] https://lore.kernel.org/lkml/ab3131a2-c42a-47ff-bf03-e9f68ac053c0@t-8ch.de/

Best regards,
Ilya

Ilya Leoshkevich (3):
  target/s390x: Fix missing interrupts for small CKC values
  target/s390x: Fix missing clock-comparator interrupts after reset
  tests/tcg/s390x: Test SET CLOCK COMPARATOR

 hw/s390x/s390-virtio-ccw.c              |  6 +--
 target/s390x/cpu.c                      |  8 ++++
 target/s390x/tcg/misc_helper.c          | 12 ++++--
 tests/tcg/s390x/Makefile.softmmu-target |  1 +
 tests/tcg/s390x/sckc.S                  | 53 +++++++++++++++++++++++++
 5 files changed, 73 insertions(+), 7 deletions(-)
 create mode 100644 tests/tcg/s390x/sckc.S

-- 
2.51.0

Re: [PATCH 0/3] target/s390x: Fix missing clock-comparator interrupts

Posted by Michael Tokarev 1 month ago

14.10.2025 19:05, Ilya Leoshkevich wrote:
> Hi,
> 
> While trying to (so far unsuccessfully) reproduce [1], I found two bugs
> in the clock comparator handling. This series fixes both and adds a
> test.
> 
> [1] https://lore.kernel.org/lkml/ab3131a2-c42a-47ff-bf03-e9f68ac053c0@t-8ch.de/
> 
> Best regards,
> Ilya
> 
> Ilya Leoshkevich (3):
>    target/s390x: Fix missing interrupts for small CKC values
>    target/s390x: Fix missing clock-comparator interrupts after reset
>    tests/tcg/s390x: Test SET CLOCK COMPARATOR

Are these worth to have in qemu stable series?

(And please don't forget to add Cc: qemu-stable@ to other future
changes which are also good to have in stable series).

Thanks,

/mjt