[PATCH 31/33] qapi/virtio.json: docs: width=70 and two spaces between sentences

Vladimir Sementsov-Ogievskiy posted 33 patches 1 month ago
Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <anisinha@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, Jason Wang <jasowang@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Jiri Pirko <jiri@resnulli.us>, Stefan Berger <stefanb@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, Mads Ynddal <mads@ynddal.dk>, Alex Williamson <alex.williamson@redhat.com>, "Cédric Le Goater" <clg@redhat.com>, Michael Roth <michael.roth@amd.com>, Kostiantyn Kostiuk <kkostiuk@redhat.com>
There is a newer version of this series
[PATCH 31/33] qapi/virtio.json: docs: width=70 and two spaces between sentences
Posted by Vladimir Sementsov-Ogievskiy 1 month ago
For x-query-virtio-status just drop the examples. No idea how
to bring them into 70 columns width. And the command is unstable
anyway.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
 qapi/virtio.json | 269 ++++-------------------------------------------
 1 file changed, 20 insertions(+), 249 deletions(-)

diff --git a/qapi/virtio.json b/qapi/virtio.json
index 05295ab665..5e5250944c 100644
--- a/qapi/virtio.json
+++ b/qapi/virtio.json
@@ -42,23 +42,23 @@
 #     <- { "return": [
 #              {
 #                  "name": "virtio-input",
-#                  "path": "/machine/peripheral-anon/device[4]/virtio-backend"
+#                  "path": "/machine/peripheral-anon/device[4]/vir..."
 #              },
 #              {
 #                  "name": "virtio-crypto",
-#                  "path": "/machine/peripheral/crypto0/virtio-backend"
+#                  "path": "/machine/peripheral/crypto0/virtio-bac..."
 #              },
 #              {
 #                  "name": "virtio-scsi",
-#                  "path": "/machine/peripheral-anon/device[2]/virtio-backend"
+#                  "path": "/machine/peripheral-anon/device[2]/vir..."
 #              },
 #              {
 #                  "name": "virtio-net",
-#                  "path": "/machine/peripheral-anon/device[1]/virtio-backend"
+#                  "path": "/machine/peripheral-anon/device[1]/vir..."
 #              },
 #              {
 #                  "name": "virtio-serial",
-#                  "path": "/machine/peripheral-anon/device[0]/virtio-backend"
+#                  "path": "/machine/peripheral-anon/device[0]/vir..."
 #              }
 #          ]
 #        }
@@ -204,239 +204,6 @@
 # Returns: Status of the virtio device
 #
 # Since: 7.2
-#
-# .. qmp-example::
-#    :annotated:
-#
-#    Poll for the status of virtio-crypto (no vhost-crypto active)
-#    ::
-#
-#     -> { "execute": "x-query-virtio-status",
-#          "arguments": { "path": "/machine/peripheral/crypto0/virtio-backend" }
-#        }
-#     <- { "return": {
-#              "device-endian": "little",
-#              "bus-name": "",
-#              "disable-legacy-check": false,
-#              "name": "virtio-crypto",
-#              "started": true,
-#              "device-id": 20,
-#              "backend-features": {
-#                  "transports": [],
-#                  "dev-features": []
-#              },
-#              "start-on-kick": false,
-#              "isr": 1,
-#              "broken": false,
-#              "status": {
-#                  "statuses": [
-#                      "VIRTIO_CONFIG_S_ACKNOWLEDGE: Valid virtio device found",
-#                      "VIRTIO_CONFIG_S_DRIVER: Guest OS compatible with device",
-#                      "VIRTIO_CONFIG_S_FEATURES_OK: Feature negotiation complete",
-#                      "VIRTIO_CONFIG_S_DRIVER_OK: Driver setup and ready"
-#                  ]
-#              },
-#              "num-vqs": 2,
-#              "guest-features": {
-#                  "dev-features": [],
-#                  "transports": [
-#                      "VIRTIO_RING_F_EVENT_IDX: Used & avail. event fields enabled",
-#                      "VIRTIO_RING_F_INDIRECT_DESC: Indirect descriptors supported",
-#                      "VIRTIO_F_VERSION_1: Device compliant for v1 spec (legacy)"
-#                  ]
-#              },
-#              "host-features": {
-#                  "unknown-dev-features": 1073741824,
-#                  "unknown-dev-features2": 0,
-#                  "dev-features": [],
-#                  "transports": [
-#                      "VIRTIO_RING_F_EVENT_IDX: Used & avail. event fields enabled",
-#                      "VIRTIO_RING_F_INDIRECT_DESC: Indirect descriptors supported",
-#                      "VIRTIO_F_VERSION_1: Device compliant for v1 spec (legacy)",
-#                      "VIRTIO_F_ANY_LAYOUT: Device accepts arbitrary desc. layouts",
-#                      "VIRTIO_F_NOTIFY_ON_EMPTY: Notify when device runs out of avail. descs. on VQ"
-#                  ]
-#              },
-#              "use-guest-notifier-mask": true,
-#              "vm-running": true,
-#              "queue-sel": 1,
-#              "disabled": false,
-#              "vhost-started": false,
-#              "use-started": true
-#          }
-#        }
-#
-# .. qmp-example::
-#    :annotated:
-#
-#    Poll for the status of virtio-net (vhost-net is active)
-#    ::
-#
-#     -> { "execute": "x-query-virtio-status",
-#          "arguments": { "path": "/machine/peripheral-anon/device[1]/virtio-backend" }
-#        }
-#     <- { "return": {
-#              "device-endian": "little",
-#              "bus-name": "",
-#              "disabled-legacy-check": false,
-#              "name": "virtio-net",
-#              "started": true,
-#              "device-id": 1,
-#              "vhost-dev": {
-#                  "n-tmp-sections": 4,
-#                  "n-mem-sections": 4,
-#                  "max-queues": 1,
-#                  "backend-cap": 2,
-#                  "log-size": 0,
-#                  "backend-features": {
-#                      "dev-features": [],
-#                      "transports": []
-#                  },
-#                  "nvqs": 2,
-#                  "protocol-features": {
-#                      "protocols": []
-#                  },
-#                  "vq-index": 0,
-#                  "log-enabled": false,
-#                  "acked-features": {
-#                      "dev-features": [
-#                          "VIRTIO_NET_F_MRG_RXBUF: Driver can merge receive buffers"
-#                      ],
-#                      "transports": [
-#                          "VIRTIO_RING_F_EVENT_IDX: Used & avail. event fields enabled",
-#                          "VIRTIO_RING_F_INDIRECT_DESC: Indirect descriptors supported",
-#                          "VIRTIO_F_VERSION_1: Device compliant for v1 spec (legacy)"
-#                      ]
-#                  },
-#                  "features": {
-#                      "dev-features": [
-#                          "VHOST_F_LOG_ALL: Logging write descriptors supported",
-#                          "VIRTIO_NET_F_MRG_RXBUF: Driver can merge receive buffers"
-#                      ],
-#                      "transports": [
-#                          "VIRTIO_RING_F_EVENT_IDX: Used & avail. event fields enabled",
-#                          "VIRTIO_RING_F_INDIRECT_DESC: Indirect descriptors supported",
-#                          "VIRTIO_F_IOMMU_PLATFORM: Device can be used on IOMMU platform",
-#                          "VIRTIO_F_VERSION_1: Device compliant for v1 spec (legacy)",
-#                          "VIRTIO_F_ANY_LAYOUT: Device accepts arbitrary desc. layouts",
-#                          "VIRTIO_F_NOTIFY_ON_EMPTY: Notify when device runs out of avail. descs. on VQ"
-#                      ]
-#                  }
-#              },
-#              "backend-features": {
-#                  "dev-features": [
-#                      "VHOST_USER_F_PROTOCOL_FEATURES: Vhost-user protocol features negotiation supported",
-#                      "VIRTIO_NET_F_GSO: Handling GSO-type packets supported",
-#                      "VIRTIO_NET_F_CTRL_MAC_ADDR: MAC address set through control channel",
-#                      "VIRTIO_NET_F_GUEST_ANNOUNCE: Driver sending gratuitous packets supported",
-#                      "VIRTIO_NET_F_CTRL_RX_EXTRA: Extra RX mode control supported",
-#                      "VIRTIO_NET_F_CTRL_VLAN: Control channel VLAN filtering supported",
-#                      "VIRTIO_NET_F_CTRL_RX: Control channel RX mode supported",
-#                      "VIRTIO_NET_F_CTRL_VQ: Control channel available",
-#                      "VIRTIO_NET_F_STATUS: Configuration status field available",
-#                      "VIRTIO_NET_F_MRG_RXBUF: Driver can merge receive buffers",
-#                      "VIRTIO_NET_F_HOST_UFO: Device can receive UFO",
-#                      "VIRTIO_NET_F_HOST_ECN: Device can receive TSO with ECN",
-#                      "VIRTIO_NET_F_HOST_TSO6: Device can receive TSOv6",
-#                      "VIRTIO_NET_F_HOST_TSO4: Device can receive TSOv4",
-#                      "VIRTIO_NET_F_GUEST_UFO: Driver can receive UFO",
-#                      "VIRTIO_NET_F_GUEST_ECN: Driver can receive TSO with ECN",
-#                      "VIRTIO_NET_F_GUEST_TSO6: Driver can receive TSOv6",
-#                      "VIRTIO_NET_F_GUEST_TSO4: Driver can receive TSOv4",
-#                      "VIRTIO_NET_F_MAC: Device has given MAC address",
-#                      "VIRTIO_NET_F_CTRL_GUEST_OFFLOADS: Control channel offloading reconfig. supported",
-#                      "VIRTIO_NET_F_GUEST_CSUM: Driver handling packets with partial checksum supported",
-#                      "VIRTIO_NET_F_CSUM: Device handling packets with partial checksum supported"
-#                  ],
-#                  "transports": [
-#                      "VIRTIO_RING_F_EVENT_IDX: Used & avail. event fields enabled",
-#                      "VIRTIO_RING_F_INDIRECT_DESC: Indirect descriptors supported",
-#                      "VIRTIO_F_VERSION_1: Device compliant for v1 spec (legacy)",
-#                      "VIRTIO_F_ANY_LAYOUT: Device accepts arbitrary desc. layouts",
-#                      "VIRTIO_F_NOTIFY_ON_EMPTY: Notify when device runs out of avail. descs. on VQ"
-#                  ]
-#              },
-#              "start-on-kick": false,
-#              "isr": 1,
-#              "broken": false,
-#              "status": {
-#                  "statuses": [
-#                      "VIRTIO_CONFIG_S_ACKNOWLEDGE: Valid virtio device found",
-#                      "VIRTIO_CONFIG_S_DRIVER: Guest OS compatible with device",
-#                      "VIRTIO_CONFIG_S_FEATURES_OK: Feature negotiation complete",
-#                      "VIRTIO_CONFIG_S_DRIVER_OK: Driver setup and ready"
-#                  ]
-#              },
-#              "num-vqs": 3,
-#              "guest-features": {
-#                  "dev-features": [
-#                      "VIRTIO_NET_F_CTRL_MAC_ADDR: MAC address set through control channel",
-#                      "VIRTIO_NET_F_GUEST_ANNOUNCE: Driver sending gratuitous packets supported",
-#                      "VIRTIO_NET_F_CTRL_VLAN: Control channel VLAN filtering supported",
-#                      "VIRTIO_NET_F_CTRL_RX: Control channel RX mode supported",
-#                      "VIRTIO_NET_F_CTRL_VQ: Control channel available",
-#                      "VIRTIO_NET_F_STATUS: Configuration status field available",
-#                      "VIRTIO_NET_F_MRG_RXBUF: Driver can merge receive buffers",
-#                      "VIRTIO_NET_F_HOST_UFO: Device can receive UFO",
-#                      "VIRTIO_NET_F_HOST_ECN: Device can receive TSO with ECN",
-#                      "VIRTIO_NET_F_HOST_TSO6: Device can receive TSOv6",
-#                      "VIRTIO_NET_F_HOST_TSO4: Device can receive TSOv4",
-#                      "VIRTIO_NET_F_GUEST_UFO: Driver can receive UFO",
-#                      "VIRTIO_NET_F_GUEST_ECN: Driver can receive TSO with ECN",
-#                      "VIRTIO_NET_F_GUEST_TSO6: Driver can receive TSOv6",
-#                      "VIRTIO_NET_F_GUEST_TSO4: Driver can receive TSOv4",
-#                      "VIRTIO_NET_F_MAC: Device has given MAC address",
-#                      "VIRTIO_NET_F_CTRL_GUEST_OFFLOADS: Control channel offloading reconfig. supported",
-#                      "VIRTIO_NET_F_GUEST_CSUM: Driver handling packets with partial checksum supported",
-#                      "VIRTIO_NET_F_CSUM: Device handling packets with partial checksum supported"
-#                  ],
-#                  "transports": [
-#                      "VIRTIO_RING_F_EVENT_IDX: Used & avail. event fields enabled",
-#                      "VIRTIO_RING_F_INDIRECT_DESC: Indirect descriptors supported",
-#                      "VIRTIO_F_VERSION_1: Device compliant for v1 spec (legacy)"
-#                 ]
-#              },
-#              "host-features": {
-#                  "dev-features": [
-#                      "VHOST_USER_F_PROTOCOL_FEATURES: Vhost-user protocol features negotiation supported",
-#                      "VIRTIO_NET_F_GSO: Handling GSO-type packets supported",
-#                      "VIRTIO_NET_F_CTRL_MAC_ADDR: MAC address set through control channel",
-#                      "VIRTIO_NET_F_GUEST_ANNOUNCE: Driver sending gratuitous packets supported",
-#                      "VIRTIO_NET_F_CTRL_RX_EXTRA: Extra RX mode control supported",
-#                      "VIRTIO_NET_F_CTRL_VLAN: Control channel VLAN filtering supported",
-#                      "VIRTIO_NET_F_CTRL_RX: Control channel RX mode supported",
-#                      "VIRTIO_NET_F_CTRL_VQ: Control channel available",
-#                      "VIRTIO_NET_F_STATUS: Configuration status field available",
-#                      "VIRTIO_NET_F_MRG_RXBUF: Driver can merge receive buffers",
-#                      "VIRTIO_NET_F_HOST_UFO: Device can receive UFO",
-#                      "VIRTIO_NET_F_HOST_ECN: Device can receive TSO with ECN",
-#                      "VIRTIO_NET_F_HOST_TSO6: Device can receive TSOv6",
-#                      "VIRTIO_NET_F_HOST_TSO4: Device can receive TSOv4",
-#                      "VIRTIO_NET_F_GUEST_UFO: Driver can receive UFO",
-#                      "VIRTIO_NET_F_GUEST_ECN: Driver can receive TSO with ECN",
-#                      "VIRTIO_NET_F_GUEST_TSO6: Driver can receive TSOv6",
-#                      "VIRTIO_NET_F_GUEST_TSO4: Driver can receive TSOv4",
-#                      "VIRTIO_NET_F_MAC: Device has given MAC address",
-#                      "VIRTIO_NET_F_CTRL_GUEST_OFFLOADS: Control channel offloading reconfig. supported",
-#                      "VIRTIO_NET_F_GUEST_CSUM: Driver handling packets with partial checksum supported",
-#                      "VIRTIO_NET_F_CSUM: Device handling packets with partial checksum supported"
-#                  ],
-#                  "transports": [
-#                      "VIRTIO_RING_F_EVENT_IDX: Used & avail. event fields enabled",
-#                      "VIRTIO_RING_F_INDIRECT_DESC: Indirect descriptors supported",
-#                      "VIRTIO_F_VERSION_1: Device compliant for v1 spec (legacy)",
-#                      "VIRTIO_F_ANY_LAYOUT: Device accepts arbitrary desc. layouts",
-#                      "VIRTIO_F_NOTIFY_ON_EMPTY: Notify when device runs out of avail. descs. on VQ"
-#                 ]
-#              },
-#              "use-guest-notifier-mask": true,
-#              "vm-running": true,
-#              "queue-sel": 2,
-#              "disabled": false,
-#              "vhost-started": true,
-#              "use-started": true
-#          }
-#        }
 ##
 { 'command': 'x-query-virtio-status',
   'data': { 'path': 'str' },
@@ -588,8 +355,9 @@
 #    ::
 #
 #     -> { "execute": "x-query-virtio-queue-status",
-#          "arguments": { "path": "/machine/peripheral/vsock0/virtio-backend",
-#                         "queue": 1 }
+#          "arguments": {
+#            "path": "/machine/peripheral/vsock0/virtio-backend",
+#            "queue": 1 }
 #        }
 #     <- { "return": {
 #              "signalled-used": 0,
@@ -615,8 +383,9 @@
 #    ::
 #
 #     -> { "execute": "x-query-virtio-queue-status",
-#          "arguments": { "path": "/machine/peripheral-anon/device[0]/virtio-backend",
-#                         "queue": 20 }
+#          "arguments": {
+#            "path": "/machine/peripheral-anon/device[0]/virtio-b...",
+#            "queue": 20 }
 #        }
 #     <- { "return": {
 #              "signalled-used": 0,
@@ -713,8 +482,9 @@
 #    :title: Get vhost_virtqueue status for vhost-crypto
 #
 #     -> { "execute": "x-query-virtio-vhost-queue-status",
-#          "arguments": { "path": "/machine/peripheral/crypto0/virtio-backend",
-#                         "queue": 0 }
+#          "arguments": {
+#            "path": "/machine/peripheral/crypto0/virtio-backend",
+#            "queue": 0 }
 #        }
 #     <- { "return": {
 #              "avail-phys": 5216124928,
@@ -737,8 +507,9 @@
 #    :title: Get vhost_virtqueue status for vhost-vsock
 #
 #     -> { "execute": "x-query-virtio-vhost-queue-status",
-#          "arguments": { "path": "/machine/peripheral/vsock0/virtio-backend",
-#                         "queue": 0 }
+#          "arguments": {
+#            "path": "/machine/peripheral/vsock0/virtio-backend",
+#            "queue": 0 }
 #        }
 #     <- { "return": {
 #              "avail-phys": 5182261248,
@@ -860,7 +631,7 @@
 #    :title: Introspect on virtio-net's VirtQueue 0 at index 5
 #
 #     -> { "execute": "x-query-virtio-queue-element",
-#          "arguments": { "path": "/machine/peripheral-anon/device[1]/virtio-backend",
+#          "arguments": { "path": "/machine/peripheral-anon/...",
 #                         "queue": 0,
 #                         "index": 5 }
 #        }
@@ -890,7 +661,7 @@
 #    :title: Introspect on virtio-crypto's VirtQueue 1 at head
 #
 #     -> { "execute": "x-query-virtio-queue-element",
-#          "arguments": { "path": "/machine/peripheral/crypto0/virtio-backend",
+#          "arguments": { "path": "/machine/peripheral/crypto0/...",
 #                         "queue": 1 }
 #        }
 #     <- { "return": {
@@ -919,7 +690,7 @@
 #    :title: Introspect on virtio-scsi's VirtQueue 2 at head
 #
 #     -> { "execute": "x-query-virtio-queue-element",
-#          "arguments": { "path": "/machine/peripheral-anon/device[2]/virtio-backend",
+#          "arguments": { "path": "/machine/peripheral-anon/...",
 #                         "queue": 2 }
 #        }
 #     <- { "return": {
-- 
2.48.1