target/tricore: Remove all uses of target_ulong types

[PATCH 04/12] target/tricore: Remove target_ulong use in gen_addi_d()

Posted by Philippe Mathieu-Daudé 1 month ago

Callers pass either int32_t or int16_t.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/tricore/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 4b769b204ab..116f45135bb 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -1308,7 +1308,7 @@ gen_msubui64_d(TCGv ret_low, TCGv ret_high, TCGv r1, TCGv r2_low, TCGv r2_high,
     gen_msubu64_d(ret_low, ret_high, r1, r2_low, r2_high, temp);
 }
 
-static inline void gen_addi_d(TCGv ret, TCGv r1, target_ulong r2)
+static inline void gen_addi_d(TCGv ret, TCGv r1, int32_t r2)
 {
     TCGv temp = tcg_constant_i32(r2);
     gen_add_d(ret, r1, temp);
-- 
2.51.0

Re: [PATCH 04/12] target/tricore: Remove target_ulong use in gen_addi_d()

Posted by Richard Henderson 1 month ago

On 10/9/25 22:21, Philippe Mathieu-Daudé wrote:
> Callers pass either int32_t or int16_t.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/tricore/translate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/tricore/translate.c b/target/tricore/translate.c
> index 4b769b204ab..116f45135bb 100644
> --- a/target/tricore/translate.c
> +++ b/target/tricore/translate.c
> @@ -1308,7 +1308,7 @@ gen_msubui64_d(TCGv ret_low, TCGv ret_high, TCGv r1, TCGv r2_low, TCGv r2_high,
>       gen_msubu64_d(ret_low, ret_high, r1, r2_low, r2_high, temp);
>   }
>   
> -static inline void gen_addi_d(TCGv ret, TCGv r1, target_ulong r2)
> +static inline void gen_addi_d(TCGv ret, TCGv r1, int32_t r2)
>   {
>       TCGv temp = tcg_constant_i32(r2);
>       gen_add_d(ret, r1, temp);

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~