target/tricore: Remove all uses of target_ulong types

[PATCH 03/12] target/tricore: Remove target_ulong use in translate_insn() handler

Posted by Philippe Mathieu-Daudé 1 month ago

Since commit 85c19af63e7 ("include/exec: Use vaddr in DisasContextBase
for virtual addresses") the DisasContextBase::pc_first field is a
vaddr type.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/tricore/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index dd09f0651f5..4b769b204ab 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -8414,7 +8414,7 @@ static void tricore_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
     ctx->base.pc_next = ctx->pc_succ_insn;
 
     if (ctx->base.is_jmp == DISAS_NEXT) {
-        target_ulong page_start;
+        vaddr page_start;
 
         page_start = ctx->base.pc_first & TARGET_PAGE_MASK;
         if (ctx->base.pc_next - page_start >= TARGET_PAGE_SIZE
-- 
2.51.0

Re: [PATCH 03/12] target/tricore: Remove target_ulong use in translate_insn() handler

Posted by Richard Henderson 1 month ago

On 10/9/25 22:21, Philippe Mathieu-Daudé wrote:
> Since commit 85c19af63e7 ("include/exec: Use vaddr in DisasContextBase
> for virtual addresses") the DisasContextBase::pc_first field is a
> vaddr type.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/tricore/translate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/tricore/translate.c b/target/tricore/translate.c
> index dd09f0651f5..4b769b204ab 100644
> --- a/target/tricore/translate.c
> +++ b/target/tricore/translate.c
> @@ -8414,7 +8414,7 @@ static void tricore_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
>       ctx->base.pc_next = ctx->pc_succ_insn;
>   
>       if (ctx->base.is_jmp == DISAS_NEXT) {
> -        target_ulong page_start;
> +        vaddr page_start;
>   
>           page_start = ctx->base.pc_first & TARGET_PAGE_MASK;
>           if (ctx->base.pc_next - page_start >= TARGET_PAGE_SIZE

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~