target/tricore: Remove all uses of target_ulong types

[PATCH 02/12] target/tricore: Replace target_ulong -> vaddr with tlb_fill() callees

Posted by Philippe Mathieu-Daudé 1 month ago

tlb_fill() provides a vaddr type since commit 68d6eee73c
("target/tricore: Convert to CPUClass::tlb_fill").

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/tricore/helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/tricore/helper.c b/target/tricore/helper.c
index e4c53d453dd..7574111c87d 100644
--- a/target/tricore/helper.c
+++ b/target/tricore/helper.c
@@ -35,7 +35,7 @@ enum {
 };
 
 static int get_physical_address(CPUTriCoreState *env, hwaddr *physical,
-                                int *prot, target_ulong address,
+                                int *prot, vaddr address,
                                 MMUAccessType access_type, int mmu_idx)
 {
     int ret = TLBRET_MATCH;
@@ -61,7 +61,7 @@ hwaddr tricore_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
 }
 
 /* TODO: Add exception support */
-static void raise_mmu_exception(CPUTriCoreState *env, target_ulong address,
+static void raise_mmu_exception(CPUTriCoreState *env, vaddr address,
                                 int rw, int tlb_error)
 {
 }
-- 
2.51.0

Re: [PATCH 02/12] target/tricore: Replace target_ulong -> vaddr with tlb_fill() callees

Posted by Richard Henderson 1 month ago

On 10/9/25 22:21, Philippe Mathieu-Daudé wrote:
> tlb_fill() provides a vaddr type since commit 68d6eee73c
> ("target/tricore: Convert to CPUClass::tlb_fill").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/tricore/helper.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/tricore/helper.c b/target/tricore/helper.c
> index e4c53d453dd..7574111c87d 100644
> --- a/target/tricore/helper.c
> +++ b/target/tricore/helper.c
> @@ -35,7 +35,7 @@ enum {
>   };
>   
>   static int get_physical_address(CPUTriCoreState *env, hwaddr *physical,
> -                                int *prot, target_ulong address,
> +                                int *prot, vaddr address,
>                                   MMUAccessType access_type, int mmu_idx)
>   {
>       int ret = TLBRET_MATCH;
> @@ -61,7 +61,7 @@ hwaddr tricore_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
>   }
>   
>   /* TODO: Add exception support */
> -static void raise_mmu_exception(CPUTriCoreState *env, target_ulong address,
> +static void raise_mmu_exception(CPUTriCoreState *env, vaddr address,
>                                   int rw, int tlb_error)
>   {
>   }

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~