target/rx: Remove target_ulong and MO_TE uses

[PATCH 7/8] target/rx: Replace MO_TE -> MO_LE

Posted by Philippe Mathieu-Daudé 1 month ago

We only build the RX targets using little endianness order:

  $ git grep TARGET_BIG_ENDIAN configs/targets/rx-*
  $

Therefore the MO_TE definition always expands to MO_LE.
Use the latter to simplify.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/rx/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/rx/translate.c b/target/rx/translate.c
index 01a065f937a..c83e7afc60f 100644
--- a/target/rx/translate.c
+++ b/target/rx/translate.c
@@ -74,7 +74,7 @@ static TCGv_i64 cpu_acc;
 
 static inline MemOp mo_endian(DisasContext *dc)
 {
-    return MO_TE;
+    return MO_LE;
 }
 
 /* decoder helper */
-- 
2.51.0

Re: [PATCH 7/8] target/rx: Replace MO_TE -> MO_LE

Posted by Richard Henderson 1 month ago

On 10/9/25 08:16, Philippe Mathieu-Daudé wrote:
> We only build the RX targets using little endianness order:
> 
>    $ git grep TARGET_BIG_ENDIAN configs/targets/rx-*
>    $
> 
> Therefore the MO_TE definition always expands to MO_LE.
> Use the latter to simplify.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/rx/translate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/rx/translate.c b/target/rx/translate.c
> index 01a065f937a..c83e7afc60f 100644
> --- a/target/rx/translate.c
> +++ b/target/rx/translate.c
> @@ -74,7 +74,7 @@ static TCGv_i64 cpu_acc;
>   
>   static inline MemOp mo_endian(DisasContext *dc)
>   {
> -    return MO_TE;
> +    return MO_LE;
>   }
>   
>   /* decoder helper */

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~