[v2] target/openrisc: Remove all uses of target_[u]long types

[PATCH v2 05/10] target/openrisc: Remove unused cpu_openrisc_map_address_*() handlers

Posted by Philippe Mathieu-Daudé 1 month ago

Commit 23d45ebdb19 ("target/openrisc: Remove indirect
function calls for mmu") removed the last uses of both
cpu_openrisc_map_address_code() and
cpu_openrisc_map_address_data() helpers.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Anton Johansson <anjo@rev.ng>
---
 target/openrisc/cpu.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/target/openrisc/cpu.h b/target/openrisc/cpu.h
index f4bcf00b073..87201365a91 100644
--- a/target/openrisc/cpu.h
+++ b/target/openrisc/cpu.h
@@ -220,15 +220,6 @@ typedef struct OpenRISCTLBEntry {
 typedef struct CPUOpenRISCTLBContext {
     OpenRISCTLBEntry itlb[TLB_SIZE];
     OpenRISCTLBEntry dtlb[TLB_SIZE];
-
-    int (*cpu_openrisc_map_address_code)(OpenRISCCPU *cpu,
-                                         hwaddr *physical,
-                                         int *prot,
-                                         target_ulong address, int rw);
-    int (*cpu_openrisc_map_address_data)(OpenRISCCPU *cpu,
-                                         hwaddr *physical,
-                                         int *prot,
-                                         target_ulong address, int rw);
 } CPUOpenRISCTLBContext;
 #endif
 
-- 
2.51.0

Re: [PATCH v2 05/10] target/openrisc: Remove unused cpu_openrisc_map_address_*() handlers

Posted by Richard Henderson 1 month ago

On 10/9/25 01:18, Philippe Mathieu-Daudé wrote:
> Commit 23d45ebdb19 ("target/openrisc: Remove indirect
> function calls for mmu") removed the last uses of both
> cpu_openrisc_map_address_code() and
> cpu_openrisc_map_address_data() helpers.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Anton Johansson <anjo@rev.ng>
> ---
>   target/openrisc/cpu.h | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/target/openrisc/cpu.h b/target/openrisc/cpu.h
> index f4bcf00b073..87201365a91 100644
> --- a/target/openrisc/cpu.h
> +++ b/target/openrisc/cpu.h
> @@ -220,15 +220,6 @@ typedef struct OpenRISCTLBEntry {
>   typedef struct CPUOpenRISCTLBContext {
>       OpenRISCTLBEntry itlb[TLB_SIZE];
>       OpenRISCTLBEntry dtlb[TLB_SIZE];
> -
> -    int (*cpu_openrisc_map_address_code)(OpenRISCCPU *cpu,
> -                                         hwaddr *physical,
> -                                         int *prot,
> -                                         target_ulong address, int rw);
> -    int (*cpu_openrisc_map_address_data)(OpenRISCCPU *cpu,
> -                                         hwaddr *physical,
> -                                         int *prot,
> -                                         target_ulong address, int rw);
>   } CPUOpenRISCTLBContext;
>   #endif
>   

Oops, my bad.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~