[v2] Introduce AspeedCoprocessor class and base implementation

[PATCH v2 00/16] Introduce AspeedCoprocessor class and base implementation

Jamin Lin via posted 16 patches 1 month ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251009023301.4085829-1-jamin._5Flin@aspeedtech.com

Maintainers: "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>

There is a newer version of this series

include/hw/arm/aspeed_coprocessor.h |  62 ++++++++++++++
include/hw/arm/aspeed_soc.h         |  51 ++++-------
hw/arm/aspeed.c                     |  10 ++-
hw/arm/aspeed_ast10x0.c             |  92 ++++++++++++--------
hw/arm/aspeed_ast2400.c             |  97 ++++++++++++---------
hw/arm/aspeed_ast2600.c             | 126 +++++++++++++++++-----------
hw/arm/aspeed_ast27x0-fc.c          |  33 +++++---
hw/arm/aspeed_ast27x0-ssp.c         |  73 ++++++++--------
hw/arm/aspeed_ast27x0-tsp.c         |  73 ++++++++--------
hw/arm/aspeed_ast27x0.c             | 109 +++++++++++++-----------
hw/arm/aspeed_coprocessor_common.c  |  49 +++++++++++
hw/arm/aspeed_soc_common.c          |  63 +++++++-------
hw/arm/fby35.c                      |  10 ++-
hw/arm/meson.build                  |   7 +-
14 files changed, 524 insertions(+), 331 deletions(-)
create mode 100644 include/hw/arm/aspeed_coprocessor.h
create mode 100644 hw/arm/aspeed_coprocessor_common.c

Expand all Fold all

[PATCH v2 00/16] Introduce AspeedCoprocessor class and base implementation

Posted by Jamin Lin via 1 month ago

v1:
  1. Remove AspeedSoCState dependency from aspeed_uart_first, aspeed_uart_last,
     aspeed_soc_uart_set_chr, aspeed_soc_cpu_type, aspeed_mmio_map,
     aspeed_mmio_map_unimplemented, aspeed_soc_get_irq, and
     aspeed_soc_uart_realize APIs.
  2. Introduce AspeedCoprocessor class and base implementation

v2:
  Fix the "make check" failure.

Jamin Lin (16):
  hw/arm/aspeed: Remove AspeedSoCState dependency from
    aspeed_uart_first() API
  hw/arm/aspeed: Remove AspeedSoCClass dependency from
    aspeed_uart_last() API
  hw/arm/aspeed: Remove AspeedSoCState dependency from
    aspeed_soc_uart_set_chr() API
  hw/arm/aspeed: Remove AspeedSoCClass dependency from
    aspeed_soc_cpu_type() API
  hw/arm/aspeed: Remove AspeedSoCState dependency from aspeed_mmio_map()
    API
  hw/arm/aspeed: Remove AspeedSoCState dependency from
    aspeed_mmio_map_unimplemented() API
  hw/arm/aspeed: Remove AspeedSoCState dependency from
    aspeed_soc_get_irq() API
  hw/arm/aspeed: Remove AspeedSoCState dependency from
    aspeed_soc_uart_realize() API
  hw/arm/aspeed: Introduce AspeedCoprocessor class and base
    implementation
  hw/arm/aspeed_ast27x0-ssp: Make AST27x0 SSP inherit from
    AspeedCoprocessor instead of AspeedSoC
  hw/arm/aspeed_ast27x0-tsp: Make AST27x0 TSP inherit from
    AspeedCoprocessor instead of AspeedSoC
  hw/arm/aspeed_ast27x0-ssp: Change to use Aspeed27x0CoprocessorState
  hw/arm/aspeed_ast27x0-tsp: Change to use Aspeed27x0CoprocessorState
  hw/arm/aspeed_ast27x0-ssp: Rename type to
    TYPE_ASPEED27X0SSP_COPROCESSOR
  hw/arm/aspeed_ast27x0-tsp: Rename type to
    TYPE_ASPEED27X0TSP_COPROCESSOR
  hw/arm/aspeed_ast27x0-{ssp,tsp}: Fix coding style

 include/hw/arm/aspeed_coprocessor.h |  62 ++++++++++++++
 include/hw/arm/aspeed_soc.h         |  51 ++++-------
 hw/arm/aspeed.c                     |  10 ++-
 hw/arm/aspeed_ast10x0.c             |  92 ++++++++++++--------
 hw/arm/aspeed_ast2400.c             |  97 ++++++++++++---------
 hw/arm/aspeed_ast2600.c             | 126 +++++++++++++++++-----------
 hw/arm/aspeed_ast27x0-fc.c          |  33 +++++---
 hw/arm/aspeed_ast27x0-ssp.c         |  73 ++++++++--------
 hw/arm/aspeed_ast27x0-tsp.c         |  73 ++++++++--------
 hw/arm/aspeed_ast27x0.c             | 109 +++++++++++++-----------
 hw/arm/aspeed_coprocessor_common.c  |  49 +++++++++++
 hw/arm/aspeed_soc_common.c          |  63 +++++++-------
 hw/arm/fby35.c                      |  10 ++-
 hw/arm/meson.build                  |   7 +-
 14 files changed, 524 insertions(+), 331 deletions(-)
 create mode 100644 include/hw/arm/aspeed_coprocessor.h
 create mode 100644 hw/arm/aspeed_coprocessor_common.c

-- 
2.43.0

Re: [SPAM] [PATCH v2 00/16] Introduce AspeedCoprocessor class and base implementation

Posted by Cédric Le Goater 1 month ago

Jamin,

On 10/9/25 04:32, Jamin Lin wrote:
> v1:
>    1. Remove AspeedSoCState dependency from aspeed_uart_first, aspeed_uart_last,
>       aspeed_soc_uart_set_chr, aspeed_soc_cpu_type, aspeed_mmio_map,
>       aspeed_mmio_map_unimplemented, aspeed_soc_get_irq, and
>       aspeed_soc_uart_realize APIs.
>    2. Introduce AspeedCoprocessor class and base implementation
> 
> v2:
>    Fix the "make check" failure.


A part from patch 7, the changes look good.


Thanks,

C.



> Jamin Lin (16):
>    hw/arm/aspeed: Remove AspeedSoCState dependency from
>      aspeed_uart_first() API
>    hw/arm/aspeed: Remove AspeedSoCClass dependency from
>      aspeed_uart_last() API
>    hw/arm/aspeed: Remove AspeedSoCState dependency from
>      aspeed_soc_uart_set_chr() API
>    hw/arm/aspeed: Remove AspeedSoCClass dependency from
>      aspeed_soc_cpu_type() API
>    hw/arm/aspeed: Remove AspeedSoCState dependency from aspeed_mmio_map()
>      API
>    hw/arm/aspeed: Remove AspeedSoCState dependency from
>      aspeed_mmio_map_unimplemented() API
>    hw/arm/aspeed: Remove AspeedSoCState dependency from
>      aspeed_soc_get_irq() API
>    hw/arm/aspeed: Remove AspeedSoCState dependency from
>      aspeed_soc_uart_realize() API
>    hw/arm/aspeed: Introduce AspeedCoprocessor class and base
>      implementation
>    hw/arm/aspeed_ast27x0-ssp: Make AST27x0 SSP inherit from
>      AspeedCoprocessor instead of AspeedSoC
>    hw/arm/aspeed_ast27x0-tsp: Make AST27x0 TSP inherit from
>      AspeedCoprocessor instead of AspeedSoC
>    hw/arm/aspeed_ast27x0-ssp: Change to use Aspeed27x0CoprocessorState
>    hw/arm/aspeed_ast27x0-tsp: Change to use Aspeed27x0CoprocessorState
>    hw/arm/aspeed_ast27x0-ssp: Rename type to
>      TYPE_ASPEED27X0SSP_COPROCESSOR
>    hw/arm/aspeed_ast27x0-tsp: Rename type to
>      TYPE_ASPEED27X0TSP_COPROCESSOR
>    hw/arm/aspeed_ast27x0-{ssp,tsp}: Fix coding style
> 
>   include/hw/arm/aspeed_coprocessor.h |  62 ++++++++++++++
>   include/hw/arm/aspeed_soc.h         |  51 ++++-------
>   hw/arm/aspeed.c                     |  10 ++-
>   hw/arm/aspeed_ast10x0.c             |  92 ++++++++++++--------
>   hw/arm/aspeed_ast2400.c             |  97 ++++++++++++---------
>   hw/arm/aspeed_ast2600.c             | 126 +++++++++++++++++-----------
>   hw/arm/aspeed_ast27x0-fc.c          |  33 +++++---
>   hw/arm/aspeed_ast27x0-ssp.c         |  73 ++++++++--------
>   hw/arm/aspeed_ast27x0-tsp.c         |  73 ++++++++--------
>   hw/arm/aspeed_ast27x0.c             | 109 +++++++++++++-----------
>   hw/arm/aspeed_coprocessor_common.c  |  49 +++++++++++
>   hw/arm/aspeed_soc_common.c          |  63 +++++++-------
>   hw/arm/fby35.c                      |  10 ++-
>   hw/arm/meson.build                  |   7 +-
>   14 files changed, 524 insertions(+), 331 deletions(-)
>   create mode 100644 include/hw/arm/aspeed_coprocessor.h
>   create mode 100644 hw/arm/aspeed_coprocessor_common.c
>