[PATCH 1/2] target/xtensa: Remove target_ulong use in xtensa_tr_translate_insn()

Philippe Mathieu-Daudé posted 2 patches 1 month, 1 week ago
Maintainers: Max Filippov <jcmvbkbc@gmail.com>
[PATCH 1/2] target/xtensa: Remove target_ulong use in xtensa_tr_translate_insn()
Posted by Philippe Mathieu-Daudé 1 month, 1 week ago
Since commit 85c19af63e7 ("include/exec: Use vaddr in DisasContextBase
for virtual addresses") the DisasContextBase::pc_first field is a
vaddr type.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/xtensa/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 34ae2f4e162..bb8d2ed86cf 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -1166,7 +1166,7 @@ static void xtensa_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
 {
     DisasContext *dc = container_of(dcbase, DisasContext, base);
     CPUXtensaState *env = cpu_env(cpu);
-    target_ulong page_start;
+    vaddr page_start;
 
     /* These two conditions only apply to the first insn in the TB,
        but this is the first TranslateOps hook that allows exiting.  */
-- 
2.51.0


Re: [PATCH 1/2] target/xtensa: Remove target_ulong use in xtensa_tr_translate_insn()
Posted by Anton Johansson via 1 month, 1 week ago
On 08/10/25, Philippe Mathieu-Daudé wrote:
> Since commit 85c19af63e7 ("include/exec: Use vaddr in DisasContextBase
> for virtual addresses") the DisasContextBase::pc_first field is a
> vaddr type.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/xtensa/translate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
> index 34ae2f4e162..bb8d2ed86cf 100644
> --- a/target/xtensa/translate.c
> +++ b/target/xtensa/translate.c
> @@ -1166,7 +1166,7 @@ static void xtensa_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
>  {
>      DisasContext *dc = container_of(dcbase, DisasContext, base);
>      CPUXtensaState *env = cpu_env(cpu);
> -    target_ulong page_start;
> +    vaddr page_start;
>  
>      /* These two conditions only apply to the first insn in the TB,
>         but this is the first TranslateOps hook that allows exiting.  */
> -- 
> 2.51.0
> 

Reviewed-by: Anton Johansson <anjo@rev.ng>