1. Patchew
  2. QEMU
  3. View series

[PATCH] migration: HMP: Adjust the order of output fields

Bin Guo posted 1 patch 1 month, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250929021213.28369-1-guobin@linux.alibaba.com
Maintainers: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>
migration/migration-hmp-cmds.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
[PATCH] migration: HMP: Adjust the order of output fields
Posted by Bin Guo 1 month, 2 weeks ago 
Adjust the positions of 'tls-authz' and 'max-postcopy-bandwidth' in
the fields output by the 'info migrate_parameters' command so that
related fields are next to each other.

For clarity only, no functional changes.

Sample output after this commit:
(qemu) info migrate_parameters
...
max-cpu-throttle: 99
tls-creds: ''
tls-hostname: ''
tls-authz: ''
max-bandwidth: 134217728 bytes/second
avail-switchover-bandwidth: 0 bytes/second
max-postcopy-bandwidth: 0 bytes/second
downtime-limit: 300 ms
...

Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
---
 migration/migration-hmp-cmds.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index 0fc21f0647..814221b260 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -353,6 +353,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
         monitor_printf(mon, "%s: '%s'\n",
             MigrationParameter_str(MIGRATION_PARAMETER_TLS_HOSTNAME),
             params->tls_hostname);
+        assert(params->tls_authz);
+        monitor_printf(mon, "%s: '%s'\n",
+            MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
+            params->tls_authz);
         assert(params->has_max_bandwidth);
         monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
             MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH),
@@ -361,6 +365,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
         monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
             MigrationParameter_str(MIGRATION_PARAMETER_AVAIL_SWITCHOVER_BANDWIDTH),
             params->avail_switchover_bandwidth);
+        assert(params->has_max_postcopy_bandwidth);
+        monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
+            MigrationParameter_str(MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH),
+            params->max_postcopy_bandwidth);
         assert(params->has_downtime_limit);
         monitor_printf(mon, "%s: %" PRIu64 " ms\n",
             MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT),
@@ -383,12 +391,6 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
         monitor_printf(mon, "%s: %" PRIu64 " bytes\n",
             MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE),
             params->xbzrle_cache_size);
-        monitor_printf(mon, "%s: %" PRIu64 "\n",
-            MigrationParameter_str(MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH),
-            params->max_postcopy_bandwidth);
-        monitor_printf(mon, "%s: '%s'\n",
-            MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
-            params->tls_authz);
 
         if (params->has_block_bitmap_mapping) {
             const BitmapMigrationNodeAliasList *bmnal;
-- 
2.39.5
Re: [PATCH] migration: HMP: Adjust the order of output fields
Posted by Fabiano Rosas 1 month, 2 weeks ago 
Bin Guo <guobin@linux.alibaba.com> writes:

> Adjust the positions of 'tls-authz' and 'max-postcopy-bandwidth' in
> the fields output by the 'info migrate_parameters' command so that
> related fields are next to each other.
>
> For clarity only, no functional changes.
>
> Sample output after this commit:
> (qemu) info migrate_parameters
> ...
> max-cpu-throttle: 99
> tls-creds: ''
> tls-hostname: ''
> tls-authz: ''
> max-bandwidth: 134217728 bytes/second
> avail-switchover-bandwidth: 0 bytes/second
> max-postcopy-bandwidth: 0 bytes/second
> downtime-limit: 300 ms
> ...
>
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Re: [PATCH] migration: HMP: Adjust the order of output fields
Posted by Peter Xu 1 month, 2 weeks ago 
On Mon, Sep 29, 2025 at 10:12:13AM +0800, Bin Guo wrote:
> Adjust the positions of 'tls-authz' and 'max-postcopy-bandwidth' in
> the fields output by the 'info migrate_parameters' command so that
> related fields are next to each other.
> 
> For clarity only, no functional changes.
> 
> Sample output after this commit:
> (qemu) info migrate_parameters
> ...
> max-cpu-throttle: 99
> tls-creds: ''
> tls-hostname: ''
> tls-authz: ''
> max-bandwidth: 134217728 bytes/second
> avail-switchover-bandwidth: 0 bytes/second
> max-postcopy-bandwidth: 0 bytes/second

This can be moved even above "avail-switchover-bandwidth", IMHO.

With that, feel free to take:

Reviewed-by: Peter Xu <peterx@redhat.com>

> downtime-limit: 300 ms
> ...
> 
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
> ---
>  migration/migration-hmp-cmds.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
> index 0fc21f0647..814221b260 100644
> --- a/migration/migration-hmp-cmds.c
> +++ b/migration/migration-hmp-cmds.c
> @@ -353,6 +353,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
>          monitor_printf(mon, "%s: '%s'\n",
>              MigrationParameter_str(MIGRATION_PARAMETER_TLS_HOSTNAME),
>              params->tls_hostname);
> +        assert(params->tls_authz);
> +        monitor_printf(mon, "%s: '%s'\n",
> +            MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
> +            params->tls_authz);
>          assert(params->has_max_bandwidth);
>          monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
>              MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH),
> @@ -361,6 +365,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
>          monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
>              MigrationParameter_str(MIGRATION_PARAMETER_AVAIL_SWITCHOVER_BANDWIDTH),
>              params->avail_switchover_bandwidth);
> +        assert(params->has_max_postcopy_bandwidth);
> +        monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
> +            MigrationParameter_str(MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH),
> +            params->max_postcopy_bandwidth);
>          assert(params->has_downtime_limit);
>          monitor_printf(mon, "%s: %" PRIu64 " ms\n",
>              MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT),
> @@ -383,12 +391,6 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
>          monitor_printf(mon, "%s: %" PRIu64 " bytes\n",
>              MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE),
>              params->xbzrle_cache_size);
> -        monitor_printf(mon, "%s: %" PRIu64 "\n",
> -            MigrationParameter_str(MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH),
> -            params->max_postcopy_bandwidth);
> -        monitor_printf(mon, "%s: '%s'\n",
> -            MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
> -            params->tls_authz);
>  
>          if (params->has_block_bitmap_mapping) {
>              const BitmapMigrationNodeAliasList *bmnal;
> -- 
> 2.39.5
> 
> 

-- 
Peter Xu
Re: [PATCH] migration: HMP: Adjust the order of output fields
Posted by Peter Xu 1 month, 2 weeks ago 
On Mon, Sep 29, 2025 at 10:12:50AM -0400, Peter Xu wrote:
> On Mon, Sep 29, 2025 at 10:12:13AM +0800, Bin Guo wrote:
> > Adjust the positions of 'tls-authz' and 'max-postcopy-bandwidth' in
> > the fields output by the 'info migrate_parameters' command so that
> > related fields are next to each other.
> > 
> > For clarity only, no functional changes.
> > 
> > Sample output after this commit:
> > (qemu) info migrate_parameters
> > ...
> > max-cpu-throttle: 99
> > tls-creds: ''
> > tls-hostname: ''
> > tls-authz: ''
> > max-bandwidth: 134217728 bytes/second
> > avail-switchover-bandwidth: 0 bytes/second
> > max-postcopy-bandwidth: 0 bytes/second
> 
> This can be moved even above "avail-switchover-bandwidth", IMHO.

I queued it with this change, please shoot if there's objections.

Thanks,

-- 
Peter Xu

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.