More recent fedora does not have our minimum python versions
anymore.  Stick with the most common fedora version used in
7.2.x in other places, which is 37.  This way, python tests
works again.

This is a 7.2-specific change, not aimed for the master branch.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 tests/docker/dockerfiles/python.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/dockerfiles/python.docker b/tests/docker/dockerfiles/python.docker
index 175c10a34e..8cc5d3567e 100644
--- a/tests/docker/dockerfiles/python.docker
+++ b/tests/docker/dockerfiles/python.docker
@@ -1,6 +1,6 @@
 # Python library testing environment
 
-FROM fedora:latest
+FROM fedora:37
 MAINTAINER John Snow <jsnow@redhat.com>
 
 # Please keep this list sorted alphabetically
-- 
2.47.3

On Fri, Sep 26, 2025 at 10:31:19AM +0300, Michael Tokarev wrote:
> More recent fedora does not have our minimum python versions
> anymore.  Stick with the most common fedora version used in
> 7.2.x in other places, which is 37.  This way, python tests
> works again.
> 
> This is a 7.2-specific change, not aimed for the master branch.
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  tests/docker/dockerfiles/python.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

On 26/9/25 10:25, Daniel P. Berrangé wrote:
> On Fri, Sep 26, 2025 at 10:31:19AM +0300, Michael Tokarev wrote:
>> More recent fedora does not have our minimum python versions
>> anymore.  Stick with the most common fedora version used in
>> 7.2.x in other places, which is 37.  This way, python tests
>> works again.

Valid change, so:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>>
>> This is a 7.2-specific change, not aimed for the master branch.

Why? We already learnt using 'latest' tag in docker image is a pain
to maintain, and hinder reproducibility. Personally I'd rather this
patch in our /master branch.

>>
>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>> ---
>>   tests/docker/dockerfiles/python.docker | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> 
> With regards,
> Daniel

On Fri, Sep 26, 2025 at 11:36:34AM +0200, Philippe Mathieu-Daudé wrote:
> On 26/9/25 10:25, Daniel P. Berrangé wrote:
> > On Fri, Sep 26, 2025 at 10:31:19AM +0300, Michael Tokarev wrote:
> > > More recent fedora does not have our minimum python versions
> > > anymore.  Stick with the most common fedora version used in
> > > 7.2.x in other places, which is 37.  This way, python tests
> > > works again.
> 
> Valid change, so:
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> > > 
> > > This is a 7.2-specific change, not aimed for the master branch.
> 
> Why? We already learnt using 'latest' tag in docker image is a pain
> to maintain, and hinder reproducibility. Personally I'd rather this
> patch in our /master branch.

Yes, we should change master too, but master will want something
much newer than Fedora 37, so this change for old stable is still
desirable as-is, as a newer Fedora won't be suitable for old
stable.

> > > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> > > ---
> > >   tests/docker/dockerfiles/python.docker | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|