[PATCH v2 0/2] isapc: remove support for -cpu host and -cpu max

Mark Cave-Ayland posted 2 patches 4 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250925160453.2025885-1-mark.caveayland@nutanix.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
docs/about/deprecated.rst | 13 +++++++++++++
hw/i386/isapc.c           | 27 ---------------------------
2 files changed, 13 insertions(+), 27 deletions(-)
[PATCH v2 0/2] isapc: remove support for -cpu host and -cpu max
Posted by Mark Cave-Ayland 4 months, 2 weeks ago
This series removes support for -cpu host and -cpu max from the isapc
machine as suggested by Igor, and then updates the "Backwards compatibility"
section of the documentation to reflect both this and the recently
introduced 32-bit x86 CPU restriction.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>

v2:
- Add documentation change suggested by Markus


Mark Cave-Ayland (2):
  hw/i386/isapc.c: remove support for -cpu host and -cpu max
  docs/about/deprecated.rst: document new restrictions for isapc CPU
    models

 docs/about/deprecated.rst | 13 +++++++++++++
 hw/i386/isapc.c           | 27 ---------------------------
 2 files changed, 13 insertions(+), 27 deletions(-)

-- 
2.43.0
Re: [PATCH v2 0/2] isapc: remove support for -cpu host and -cpu max
Posted by Igor Mammedov 4 months, 1 week ago
On Thu, 25 Sep 2025 17:03:18 +0100
Mark Cave-Ayland <mark.caveayland@nutanix.com> wrote:

> This series removes support for -cpu host and -cpu max from the isapc
> machine as suggested by Igor, and then updates the "Backwards compatibility"
> section of the documentation to reflect both this and the recently
> introduced 32-bit x86 CPU restriction.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>

so, taking in account discussion in this thread.

I'd 1st post only deprecation, and once it is run out
this patch.

With that:
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> 
> v2:
> - Add documentation change suggested by Markus
> 
> 
> Mark Cave-Ayland (2):
>   hw/i386/isapc.c: remove support for -cpu host and -cpu max
>   docs/about/deprecated.rst: document new restrictions for isapc CPU
>     models
> 
>  docs/about/deprecated.rst | 13 +++++++++++++
>  hw/i386/isapc.c           | 27 ---------------------------
>  2 files changed, 13 insertions(+), 27 deletions(-)
>
Re: [PATCH v2 0/2] isapc: remove support for -cpu host and -cpu max
Posted by Mark Cave-Ayland 4 months, 1 week ago
On 02/10/2025 14:13, Igor Mammedov wrote:

> On Thu, 25 Sep 2025 17:03:18 +0100
> Mark Cave-Ayland <mark.caveayland@nutanix.com> wrote:
> 
>> This series removes support for -cpu host and -cpu max from the isapc
>> machine as suggested by Igor, and then updates the "Backwards compatibility"
>> section of the documentation to reflect both this and the recently
>> introduced 32-bit x86 CPU restriction.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> 
> so, taking in account discussion in this thread.
> 
> I'd 1st post only deprecation, and once it is run out
> this patch.

Regarding deprecation, do I understand correctly that you are happy with 
the current restriction to 32-bit x86 CPUs added for 10.2, and it's just 
the -cpu host/-cpu max you want to go through the deprecation process?

> With that:
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>

Thanks!


ATB,

Mark.
Re: [PATCH v2 0/2] isapc: remove support for -cpu host and -cpu max
Posted by Igor Mammedov 4 months ago
On Fri, 3 Oct 2025 12:46:12 +0100
Mark Cave-Ayland <mark.caveayland@nutanix.com> wrote:

> On 02/10/2025 14:13, Igor Mammedov wrote:
> 
> > On Thu, 25 Sep 2025 17:03:18 +0100
> > Mark Cave-Ayland <mark.caveayland@nutanix.com> wrote:
> >   
> >> This series removes support for -cpu host and -cpu max from the isapc
> >> machine as suggested by Igor, and then updates the "Backwards compatibility"
> >> section of the documentation to reflect both this and the recently
> >> introduced 32-bit x86 CPU restriction.
> >>
> >> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>  
> > 
> > so, taking in account discussion in this thread.
> > 
> > I'd 1st post only deprecation, and once it is run out
> > this patch.  
> 
> Regarding deprecation, do I understand correctly that you are happy with 
> the current restriction to 32-bit x86 CPUs added for 10.2, and it's just 
> the -cpu host/-cpu max you want to go through the deprecation process?

given we haven't released any restrictions yet and it was possible to start
VM with any of cpu model. We should just revert 
   e1e2909f8e74 hw/i386/pc_piix.c: restrict isapc machine to 32-bit CPUs
for now and add deprecation message for 10.2

and then apply reduced (on max/host) variant in 2 releases.


> > With that:
> > Reviewed-by: Igor Mammedov <imammedo@redhat.com>  
> 
> Thanks!
> 
> 
> ATB,
> 
> Mark.
>