Hello Jamin,
On 9/25/25 07:05, Jamin Lin wrote:
> This patch introduces a dedicated ca35_boot_rom memory region and
> copies the FMC0 flash data into it when mmio_exec is disabled.
>
> The main purpose of this change is to support the upcoming VBOOTROM
> , which can directly fetch data from FMC0 flash at the SPI boot ROM
> base address (0x100000000) without requiring any SPI controller
> drivers.
Could you please rephrase this commit log with the explanations
provided in :
https://lore.kernel.org/qemu-devel/SI2PR06MB50417B26704FD2FAD0BB8105FC1FA@SI2PR06MB5041.apcprd06.prod.outlook.com/
(without the vbootrom URLs)
No need to resend. I will update the commit log of this patch.
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> hw/arm/aspeed_ast27x0-fc.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/aspeed_ast27x0-fc.c b/hw/arm/aspeed_ast27x0-fc.c
> index 2e16a0340a..57964e336c 100644
> --- a/hw/arm/aspeed_ast27x0-fc.c
> +++ b/hw/arm/aspeed_ast27x0-fc.c
> @@ -35,6 +35,7 @@ struct Ast2700FCState {
>
> MemoryRegion ca35_memory;
> MemoryRegion ca35_dram;
> + MemoryRegion ca35_boot_rom;
> MemoryRegion ssp_memory;
> MemoryRegion tsp_memory;
>
> @@ -44,8 +45,6 @@ struct Ast2700FCState {
> Aspeed27x0SoCState ca35;
> Aspeed27x0SSPSoCState ssp;
> Aspeed27x0TSPSoCState tsp;
> -
> - bool mmio_exec;
> };
>
> #define AST2700FC_BMC_RAM_SIZE (1 * GiB)
> @@ -61,6 +60,9 @@ static bool ast2700fc_ca35_init(MachineState *machine, Error **errp)
> Ast2700FCState *s = AST2700A1FC(machine);
> AspeedSoCState *soc;
> AspeedSoCClass *sc;
> + BlockBackend *fmc0 = NULL;
> + DeviceState *dev = NULL;
> + uint64_t rom_size;
>
> object_initialize_child(OBJECT(s), "ca35", &s->ca35, "ast2700-a1");
> soc = ASPEED_SOC(&s->ca35);
> @@ -107,6 +109,14 @@ static bool ast2700fc_ca35_init(MachineState *machine, Error **errp)
> ast2700fc_board_info.ram_size = machine->ram_size;
> ast2700fc_board_info.loader_start = sc->memmap[ASPEED_DEV_SDRAM];
>
> + dev = ssi_get_cs(soc->fmc.spi, 0);
> + fmc0 = dev ? m25p80_get_blk(dev) : NULL;
> +
> + if (fmc0) {
> + rom_size = memory_region_size(&soc->spi_boot);
> + aspeed_install_boot_rom(soc, fmc0, &s->ca35_boot_rom, rom_size);
> + }
> +
> arm_load_kernel(ARM_CPU(first_cpu), machine, &ast2700fc_board_info);
>
> return true;