accel/tcg: Remove cpu_loop_exit_restore() stub

[PATCH] accel/tcg: Remove cpu_loop_exit_restore() stub

Philippe Mathieu-Daudé posted 1 patch 3 days, 22 hours ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250924165039.52250-1-philmd@linaro.org

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>

include/exec/cpu-common.h | 2 +-
accel/stubs/tcg-stub.c    | 5 -----
2 files changed, 1 insertion(+), 6 deletions(-)

Expand all Fold all

[PATCH] accel/tcg: Remove cpu_loop_exit_restore() stub

Posted by Philippe Mathieu-Daudé 3 days, 22 hours ago

Not needed since commit 63e7af20352 ("hw/mips: Restrict ITU to TCG").

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/exec/cpu-common.h | 2 +-
 accel/stubs/tcg-stub.c    | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
index 9b658a3f48f..f373781ae07 100644
--- a/include/exec/cpu-common.h
+++ b/include/exec/cpu-common.h
@@ -221,9 +221,9 @@ static inline bool cpu_loop_exit_requested(CPUState *cpu)
 
 G_NORETURN void cpu_loop_exit_noexc(CPUState *cpu);
 G_NORETURN void cpu_loop_exit_atomic(CPUState *cpu, uintptr_t pc);
+G_NORETURN void cpu_loop_exit_restore(CPUState *cpu, uintptr_t pc);
 #endif /* CONFIG_TCG */
 G_NORETURN void cpu_loop_exit(CPUState *cpu);
-G_NORETURN void cpu_loop_exit_restore(CPUState *cpu, uintptr_t pc);
 
 /* accel/tcg/cpu-exec.c */
 int cpu_exec(CPUState *cpu);
diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
index 3b76b8b17c1..77055e39644 100644
--- a/accel/stubs/tcg-stub.c
+++ b/accel/stubs/tcg-stub.c
@@ -17,8 +17,3 @@ G_NORETURN void cpu_loop_exit(CPUState *cpu)
 {
     g_assert_not_reached();
 }
-
-G_NORETURN void cpu_loop_exit_restore(CPUState *cpu, uintptr_t pc)
-{
-    g_assert_not_reached();
-}
-- 
2.51.0

Re: [PATCH] accel/tcg: Remove cpu_loop_exit_restore() stub

Posted by Richard Henderson 3 days, 21 hours ago

On 9/24/25 09:50, Philippe Mathieu-Daudé wrote:
> Not needed since commit 63e7af20352 ("hw/mips: Restrict ITU to TCG").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/exec/cpu-common.h | 2 +-
>   accel/stubs/tcg-stub.c    | 5 -----
>   2 files changed, 1 insertion(+), 6 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

And queued.

r~

> 
> diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
> index 9b658a3f48f..f373781ae07 100644
> --- a/include/exec/cpu-common.h
> +++ b/include/exec/cpu-common.h
> @@ -221,9 +221,9 @@ static inline bool cpu_loop_exit_requested(CPUState *cpu)
>   
>   G_NORETURN void cpu_loop_exit_noexc(CPUState *cpu);
>   G_NORETURN void cpu_loop_exit_atomic(CPUState *cpu, uintptr_t pc);
> +G_NORETURN void cpu_loop_exit_restore(CPUState *cpu, uintptr_t pc);
>   #endif /* CONFIG_TCG */
>   G_NORETURN void cpu_loop_exit(CPUState *cpu);
> -G_NORETURN void cpu_loop_exit_restore(CPUState *cpu, uintptr_t pc);
>   
>   /* accel/tcg/cpu-exec.c */
>   int cpu_exec(CPUState *cpu);
> diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
> index 3b76b8b17c1..77055e39644 100644
> --- a/accel/stubs/tcg-stub.c
> +++ b/accel/stubs/tcg-stub.c
> @@ -17,8 +17,3 @@ G_NORETURN void cpu_loop_exit(CPUState *cpu)
>   {
>       g_assert_not_reached();
>   }
> -
> -G_NORETURN void cpu_loop_exit_restore(CPUState *cpu, uintptr_t pc)
> -{
> -    g_assert_not_reached();
> -}