[v1] block: Expose block limits in monitor and qemu-img info

[PATCH 0/2] block: Expose block limits in monitor and qemu-img info

Kevin Wolf posted 2 patches 4 months, 2 weeks ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250923163735.378254-1-kwolf@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>

There is a newer version of this series

qapi/block-core.json             | 59 ++++++++++++++++++++++++++++
docs/tools/qemu-img.rst          |  6 ++-
include/block/qapi.h             |  2 +-
block/qapi.c                     | 66 ++++++++++++++++++++++++++++++--
qemu-img.c                       | 15 ++++++--
qemu-img-cmds.hx                 |  4 +-
tests/qemu-iotests/184           |  3 +-
tests/qemu-iotests/184.out       |  8 ----
tests/qemu-iotests/common.filter |  3 +-
9 files changed, 145 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH 0/2] block: Expose block limits in monitor and qemu-img info

Posted by Kevin Wolf 4 months, 2 weeks ago

This information can be useful both for debugging and for management
tools trying to configure guest devices with the optimal limits
(possibly across multiple hosts). There is no reason not to make it
available, so just add it both in the monitor (QMP and HMP) and in
'qemu-img info'.

Kevin Wolf (2):
  block: Expose block limits for images in QMP
  qemu-img info: Optionally show block limits

 qapi/block-core.json             | 59 ++++++++++++++++++++++++++++
 docs/tools/qemu-img.rst          |  6 ++-
 include/block/qapi.h             |  2 +-
 block/qapi.c                     | 66 ++++++++++++++++++++++++++++++--
 qemu-img.c                       | 15 ++++++--
 qemu-img-cmds.hx                 |  4 +-
 tests/qemu-iotests/184           |  3 +-
 tests/qemu-iotests/184.out       |  8 ----
 tests/qemu-iotests/common.filter |  3 +-
 9 files changed, 145 insertions(+), 21 deletions(-)

-- 
2.51.0

Re: [PATCH 0/2] block: Expose block limits in monitor and qemu-img info

Posted by Hanna Czenczek 4 months, 1 week ago

On 23.09.25 18:37, Kevin Wolf wrote:
> This information can be useful both for debugging and for management
> tools trying to configure guest devices with the optimal limits
> (possibly across multiple hosts). There is no reason not to make it
> available, so just add it both in the monitor (QMP and HMP) and in
> 'qemu-img info'.
>
> Kevin Wolf (2):
>    block: Expose block limits for images in QMP
>    qemu-img info: Optionally show block limits

With or without the comment changes to patch 1:

Reviewed-by: Hanna Czenczek <hreitz@redhat.com>

(And I vote for keeping the paranthesized text in patch 2.)