[v1] vfio: improve naming conventions

[PATCH 21/27] vfio/pci.c: rename vfio_pci_nohotplug_dev_class_init() to vfio_pci_nohotplug_class_init()

Posted by Mark Cave-Ayland 5 days, 1 hour ago

This changes the function prefix to match the name of the QOM type.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/vfio/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index a32a507059..ec60bc3907 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3932,7 +3932,7 @@ static const Property vfio_pci_nohotplug_properties[] = {
                             ON_OFF_AUTO_AUTO),
 };
 
-static void vfio_pci_nohotplug_dev_class_init(ObjectClass *klass,
+static void vfio_pci_nohotplug_class_init(ObjectClass *klass,
                                               const void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
@@ -3957,7 +3957,7 @@ static const TypeInfo vfio_pci_nohotplug_dev_info = {
     .name = TYPE_VFIO_PCI_NOHOTPLUG,
     .parent = TYPE_VFIO_PCI,
     .instance_size = sizeof(VFIOPCIDevice),
-    .class_init = vfio_pci_nohotplug_dev_class_init,
+    .class_init = vfio_pci_nohotplug_class_init,
 };
 
 static void register_vfio_pci_dev_type(void)
-- 
2.43.0

Re: [PATCH 21/27] vfio/pci.c: rename vfio_pci_nohotplug_dev_class_init() to vfio_pci_nohotplug_class_init()

Posted by Cédric Le Goater 4 days ago

On 9/23/25 15:53, Mark Cave-Ayland wrote:
> This changes the function prefix to match the name of the QOM type.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>   hw/vfio/pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index a32a507059..ec60bc3907 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -3932,7 +3932,7 @@ static const Property vfio_pci_nohotplug_properties[] = {
>                               ON_OFF_AUTO_AUTO),
>   };
>   
> -static void vfio_pci_nohotplug_dev_class_init(ObjectClass *klass,
> +static void vfio_pci_nohotplug_class_init(ObjectClass *klass,
>                                                 const void *data)
>   {
>       DeviceClass *dc = DEVICE_CLASS(klass);
> @@ -3957,7 +3957,7 @@ static const TypeInfo vfio_pci_nohotplug_dev_info = {
>       .name = TYPE_VFIO_PCI_NOHOTPLUG,
>       .parent = TYPE_VFIO_PCI,
>       .instance_size = sizeof(VFIOPCIDevice),
> -    .class_init = vfio_pci_nohotplug_dev_class_init,
> +    .class_init = vfio_pci_nohotplug_class_init,
>   };
>   
>   static void register_vfio_pci_dev_type(void)


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.