[v1] vfio: improve naming conventions

[PATCH 17/27] vfio/pci.c: rename vfio_pci_base_dev_class_init() to vfio_pci_device_class_init()

Posted by Mark Cave-Ayland 5 days, 1 hour ago

This changes the function prefix to match the name of the QOM type.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/vfio/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 6d2ca710c8..a511f99a2c 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3660,7 +3660,7 @@ static void vfio_pci_init(Object *obj)
     pci_dev->cap_present |= QEMU_PCI_SKIP_RESET_ON_CPR;
 }
 
-static void vfio_pci_base_dev_class_init(ObjectClass *klass, const void *data)
+static void vfio_pci_device_class_init(ObjectClass *klass, const void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     PCIDeviceClass *pdc = PCI_DEVICE_CLASS(klass);
@@ -3677,7 +3677,7 @@ static const TypeInfo vfio_pci_base_dev_info = {
     .parent = TYPE_PCI_DEVICE,
     .instance_size = sizeof(VFIOPCIDevice),
     .abstract = true,
-    .class_init = vfio_pci_base_dev_class_init,
+    .class_init = vfio_pci_device_class_init,
     .interfaces = (const InterfaceInfo[]) {
         { INTERFACE_PCIE_DEVICE },
         { INTERFACE_CONVENTIONAL_PCI_DEVICE },
-- 
2.43.0

Re: [PATCH 17/27] vfio/pci.c: rename vfio_pci_base_dev_class_init() to vfio_pci_device_class_init()

Posted by Cédric Le Goater 4 days ago

On 9/23/25 15:53, Mark Cave-Ayland wrote:
> This changes the function prefix to match the name of the QOM type.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>   hw/vfio/pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 6d2ca710c8..a511f99a2c 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -3660,7 +3660,7 @@ static void vfio_pci_init(Object *obj)
>       pci_dev->cap_present |= QEMU_PCI_SKIP_RESET_ON_CPR;
>   }
>   
> -static void vfio_pci_base_dev_class_init(ObjectClass *klass, const void *data)
> +static void vfio_pci_device_class_init(ObjectClass *klass, const void *data)
>   {
>       DeviceClass *dc = DEVICE_CLASS(klass);
>       PCIDeviceClass *pdc = PCI_DEVICE_CLASS(klass);
> @@ -3677,7 +3677,7 @@ static const TypeInfo vfio_pci_base_dev_info = {
>       .parent = TYPE_PCI_DEVICE,
>       .instance_size = sizeof(VFIOPCIDevice),
>       .abstract = true,
> -    .class_init = vfio_pci_base_dev_class_init,
> +    .class_init = vfio_pci_device_class_init,
>       .interfaces = (const InterfaceInfo[]) {
>           { INTERFACE_PCIE_DEVICE },
>           { INTERFACE_CONVENTIONAL_PCI_DEVICE },

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.