[v1] vfio: improve naming conventions

[PATCH 15/27] vfio/pci.c: rename vfio_pci_dev_info to vfio_pci_info

Posted by Mark Cave-Ayland 5 days, 1 hour ago

This changes the prefix to match the name of the QOM type.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/vfio/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 3c0e678723..6e8b872275 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3916,7 +3916,7 @@ static void vfio_pci_class_init(ObjectClass *klass, const void *data)
                                           "multifd channels");
 }
 
-static const TypeInfo vfio_pci_dev_info = {
+static const TypeInfo vfio_pci_info = {
     .name = TYPE_VFIO_PCI,
     .parent = TYPE_VFIO_PCI_BASE,
     .class_init = vfio_pci_class_init,
@@ -3974,7 +3974,7 @@ static void register_vfio_pci_dev_type(void)
     vfio_pci_migration_multifd_transfer_prop.realized_set_allowed = true;
 
     type_register_static(&vfio_pci_base_dev_info);
-    type_register_static(&vfio_pci_dev_info);
+    type_register_static(&vfio_pci_info);
     type_register_static(&vfio_pci_nohotplug_dev_info);
 }
 
-- 
2.43.0

Re: [PATCH 15/27] vfio/pci.c: rename vfio_pci_dev_info to vfio_pci_info

Posted by Cédric Le Goater 4 days ago

On 9/23/25 15:53, Mark Cave-Ayland wrote:
> This changes the prefix to match the name of the QOM type.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>   hw/vfio/pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 3c0e678723..6e8b872275 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -3916,7 +3916,7 @@ static void vfio_pci_class_init(ObjectClass *klass, const void *data)
>                                             "multifd channels");
>   }
>   
> -static const TypeInfo vfio_pci_dev_info = {
> +static const TypeInfo vfio_pci_info = {
>       .name = TYPE_VFIO_PCI,
>       .parent = TYPE_VFIO_PCI_BASE,
>       .class_init = vfio_pci_class_init,
> @@ -3974,7 +3974,7 @@ static void register_vfio_pci_dev_type(void)
>       vfio_pci_migration_multifd_transfer_prop.realized_set_allowed = true;
>   
>       type_register_static(&vfio_pci_base_dev_info);
> -    type_register_static(&vfio_pci_dev_info);
> +    type_register_static(&vfio_pci_info);
>       type_register_static(&vfio_pci_nohotplug_dev_info);
>   }
>   


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.