[PATCH 13/27] vfio/pci.c: rename vfio_instance_finalize() to vfio_pci_finalize()

Mark Cave-Ayland posted 27 patches 5 days, 1 hour ago
Maintainers: Nicholas Piggin <npiggin@gmail.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, John Levon <john.levon@nutanix.com>, Thanos Makatos <thanos.makatos@nutanix.com>, "Cédric Le Goater" <clg@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, Steve Sistare <steven.sistare@oracle.com>
There is a newer version of this series
[PATCH 13/27] vfio/pci.c: rename vfio_instance_finalize() to vfio_pci_finalize()
Posted by Mark Cave-Ayland 5 days, 1 hour ago
This is the more typical naming convention for QOM finalize() functions, in
particular it changes the prefix to match the name of the QOM type.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/vfio/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 9046244e7f..020e611748 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3554,7 +3554,7 @@ error:
     error_prepend(errp, VFIO_MSG_PREFIX, vbasedev->name);
 }
 
-static void vfio_instance_finalize(Object *obj)
+static void vfio_pci_finalize(Object *obj)
 {
     VFIOPCIDevice *vdev = VFIO_PCI_BASE(obj);
 
@@ -3921,7 +3921,7 @@ static const TypeInfo vfio_pci_dev_info = {
     .parent = TYPE_VFIO_PCI_BASE,
     .class_init = vfio_pci_dev_class_init,
     .instance_init = vfio_pci_init,
-    .instance_finalize = vfio_instance_finalize,
+    .instance_finalize = vfio_pci_finalize,
 };
 
 static const Property vfio_pci_dev_nohotplug_properties[] = {
-- 
2.43.0
Re: [PATCH 13/27] vfio/pci.c: rename vfio_instance_finalize() to vfio_pci_finalize()
Posted by Cédric Le Goater 4 days ago
On 9/23/25 15:53, Mark Cave-Ayland wrote:
> This is the more typical naming convention for QOM finalize() functions, in
> particular it changes the prefix to match the name of the QOM type.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>   hw/vfio/pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 9046244e7f..020e611748 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -3554,7 +3554,7 @@ error:
>       error_prepend(errp, VFIO_MSG_PREFIX, vbasedev->name);
>   }
>   
> -static void vfio_instance_finalize(Object *obj)
> +static void vfio_pci_finalize(Object *obj)
>   {
>       VFIOPCIDevice *vdev = VFIO_PCI_BASE(obj);
>   
> @@ -3921,7 +3921,7 @@ static const TypeInfo vfio_pci_dev_info = {
>       .parent = TYPE_VFIO_PCI_BASE,
>       .class_init = vfio_pci_dev_class_init,
>       .instance_init = vfio_pci_init,
> -    .instance_finalize = vfio_instance_finalize,
> +    .instance_finalize = vfio_pci_finalize,
>   };
>   
>   static const Property vfio_pci_dev_nohotplug_properties[] = {


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.