passt: Declare dependency on gio

[PATCH] passt: Declare dependency on gio

Posted by Peter Maydell 6 days, 1 hour ago

The passt network backend uses gio; declare this dependency in
meson.build, so we don't try to build it if configured with
--disable-gio or if gio is not present.

Cc: qemu-stable@nongnu.org
Fixes: 854ee02b222 ("net: Add passt network backend")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3121
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build
index 6ade30f36ad..c5a56ba5deb 100644
--- a/meson.build
+++ b/meson.build
@@ -1279,6 +1279,7 @@ if not get_option('slirp').auto() or have_system
 endif
 
 enable_passt = get_option('passt') \
+  .require(gio.found(), error_message: 'passt requires gio') \
   .require(host_os == 'linux', error_message: 'passt is supported only on Linux') \
   .allowed()
 
-- 
2.43.0

Re: [PATCH] passt: Declare dependency on gio

Posted by Laurent Vivier 5 days, 2 hours ago

On 22/09/2025 15:22, Peter Maydell wrote:
> The passt network backend uses gio; declare this dependency in
> meson.build, so we don't try to build it if configured with
> --disable-gio or if gio is not present.
> 
> Cc: qemu-stable@nongnu.org
> Fixes: 854ee02b222 ("net: Add passt network backend")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3121
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   meson.build | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meson.build b/meson.build
> index 6ade30f36ad..c5a56ba5deb 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1279,6 +1279,7 @@ if not get_option('slirp').auto() or have_system
>   endif
>   
>   enable_passt = get_option('passt') \
> +  .require(gio.found(), error_message: 'passt requires gio') \
>     .require(host_os == 'linux', error_message: 'passt is supported only on Linux') \
>     .allowed()
>   

I sent the same patch two months ago:
https://lists.nongnu.org/archive/html/qemu-devel/2025-07/msg04907.html

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

Laurent

Re: [PATCH] passt: Declare dependency on gio

Posted by Peter Maydell 3 days, 4 hours ago

On Tue, 23 Sept 2025 at 13:52, Laurent Vivier <lvivier@redhat.com> wrote:
>
> On 22/09/2025 15:22, Peter Maydell wrote:
> > The passt network backend uses gio; declare this dependency in
> > meson.build, so we don't try to build it if configured with
> > --disable-gio or if gio is not present.
> >
> > Cc: qemu-stable@nongnu.org
> > Fixes: 854ee02b222 ("net: Add passt network backend")
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3121
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >   meson.build | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/meson.build b/meson.build
> > index 6ade30f36ad..c5a56ba5deb 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -1279,6 +1279,7 @@ if not get_option('slirp').auto() or have_system
> >   endif
> >
> >   enable_passt = get_option('passt') \
> > +  .require(gio.found(), error_message: 'passt requires gio') \
> >     .require(host_os == 'linux', error_message: 'passt is supported only on Linux') \
> >     .allowed()
> >
>
> I sent the same patch two months ago:
> https://lists.nongnu.org/archive/html/qemu-devel/2025-07/msg04907.html

Sorry, I should have searched the list and saved myself some
time :-)  I'll pick your patch up via target-arm.next.

-- PMM