On 9/22/25 00:34, Bibo Mao wrote:
> Function loongarch_exception_name() is only called in defined file
> target/loongarch/tcg/tcg_cpu.c, set this function as static.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
> target/loongarch/internals.h | 2 --
> target/loongarch/tcg/tcg_cpu.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target/loongarch/internals.h b/target/loongarch/internals.h
> index e50d109767..29956f0fbe 100644
> --- a/target/loongarch/internals.h
> +++ b/target/loongarch/internals.h
> @@ -24,8 +24,6 @@ void G_NORETURN do_raise_exception(CPULoongArchState *env,
> uint32_t exception,
> uintptr_t pc);
>
> -const char *loongarch_exception_name(int32_t exception);
> -
> #ifdef CONFIG_TCG
> int ieee_ex_to_loongarch(int xcpt);
> void restore_fp_status(CPULoongArchState *env);
> diff --git a/target/loongarch/tcg/tcg_cpu.c b/target/loongarch/tcg/tcg_cpu.c
> index 59b5800ecf..82b54e6dc3 100644
> --- a/target/loongarch/tcg/tcg_cpu.c
> +++ b/target/loongarch/tcg/tcg_cpu.c
> @@ -45,7 +45,7 @@ static const struct TypeExcp excp_names[] = {
> {EXCP_HLT, "EXCP_HLT"},
> };
>
> -const char *loongarch_exception_name(int32_t exception)
> +static const char *loongarch_exception_name(int32_t exception)
> {
> int i;
>
Ha ha. My comment vs patch 4 was anticipated.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~