rust: vmstate: use "cast()" instead of "as"

[PATCH] rust: vmstate: use "cast()" instead of "as"

Posted by Paolo Bonzini 1 month, 3 weeks ago

Reported by clippy, fix it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 rust/migration/src/vmstate.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/migration/src/vmstate.rs b/rust/migration/src/vmstate.rs
index c05c4a1fd66..e04b19b3c9f 100644
--- a/rust/migration/src/vmstate.rs
+++ b/rust/migration/src/vmstate.rs
@@ -144,7 +144,7 @@ macro_rules! vmstate_of {
         $crate::bindings::VMStateField {
             name: ::core::concat!(::core::stringify!($field_name), "\0")
                 .as_bytes()
-                .as_ptr() as *const ::std::os::raw::c_char,
+                .as_ptr().cast::<::std::os::raw::c_char>(),
             offset: ::std::mem::offset_of!($struct_name, $field_name),
             $(num_offset: ::std::mem::offset_of!($struct_name, $num),)?
             $(field_exists: $crate::vmstate_exist_fn!($struct_name, $test_fn),)?
-- 
2.51.0

Re: [PATCH] rust: vmstate: use "cast()" instead of "as"

Posted by Zhao Liu 1 month, 3 weeks ago

On Fri, Sep 19, 2025 at 10:36:25AM +0200, Paolo Bonzini wrote:
> Date: Fri, 19 Sep 2025 10:36:25 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH] rust: vmstate: use "cast()" instead of "as"
> 
> Reported by clippy, fix it.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  rust/migration/src/vmstate.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

Re: [PATCH] rust: vmstate: use "cast()" instead of "as"

Posted by Manos Pitsidianakis 1 month, 3 weeks ago

On Fri, Sep 19, 2025 at 11:37 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Reported by clippy, fix it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

>  rust/migration/src/vmstate.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/migration/src/vmstate.rs b/rust/migration/src/vmstate.rs
> index c05c4a1fd66..e04b19b3c9f 100644
> --- a/rust/migration/src/vmstate.rs
> +++ b/rust/migration/src/vmstate.rs
> @@ -144,7 +144,7 @@ macro_rules! vmstate_of {
>          $crate::bindings::VMStateField {
>              name: ::core::concat!(::core::stringify!($field_name), "\0")
>                  .as_bytes()
> -                .as_ptr() as *const ::std::os::raw::c_char,
> +                .as_ptr().cast::<::std::os::raw::c_char>(),
>              offset: ::std::mem::offset_of!($struct_name, $field_name),
>              $(num_offset: ::std::mem::offset_of!($struct_name, $num),)?
>              $(field_exists: $crate::vmstate_exist_fn!($struct_name, $test_fn),)?
> --
> 2.51.0
>
>