Fix memory region use-after-finalization

[PATCH 04/14] hw/char/diva-gsp: Do not delete the subregion

Posted by Akihiko Odaki 4 days, 15 hours ago

It is no longer necessary.

Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
---
 hw/char/diva-gsp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/char/diva-gsp.c b/hw/char/diva-gsp.c
index e1f0713cb794..1ae472e879b5 100644
--- a/hw/char/diva-gsp.c
+++ b/hw/char/diva-gsp.c
@@ -63,7 +63,6 @@ static void diva_pci_exit(PCIDevice *dev)
     for (i = 0; i < pci->ports; i++) {
         s = pci->state + i;
         qdev_unrealize(DEVICE(s));
-        memory_region_del_subregion(&pci->membar, &s->io);
         g_free(pci->name[i]);
     }
     qemu_free_irqs(pci->irqs, pci->ports);

-- 
2.51.0

[PATCH 01/14] hw/pci-bridge: Do not assume immediate MemoryRegion finalization
[PATCH 02/14] qdev: Automatically delete memory subregions
[PATCH 03/14] vfio-user: Do not delete the subregion
[PATCH 04/14] hw/char/diva-gsp: Do not delete the subregion
[PATCH 05/14] hw/char/serial-pci-multi: Do not delete the subregion
[PATCH 06/14] secondary-vga: Do not delete the subregions
[PATCH 07/14] cmd646: Do not delete the subregions
[PATCH 08/14] hw/ide/piix: Do not delete the subregions
[PATCH 09/14] hw/ide/via: Do not delete the subregions
[PATCH 10/14] hw/nvme: Do not delete the subregion
[PATCH 11/14] pci: Do not delete the subregions
[PATCH 12/14] hw/ppc/spapr_pci: Do not delete the subregions
[PATCH 13/14] hw/usb/hcd-ehci: Do not delete the subregions
[PATCH 14/14] hw/usb/hcd-xhci: Do not delete the subregions