[PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags

Peter Maydell posted 1 patch 1 month, 4 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250916163030.1467893-1-peter.maydell@linaro.org
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>
.gitlab-ci.d/buildtest.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags
Posted by Peter Maydell 1 month, 4 weeks ago
In commit 52a21689cd829 we added a workaround for a bug in older
versions of htags where they fail with a weird error message if the
environment is too large.  However, we missed one variable which
gitlab CI can set to the body of the commit message:
CI_COMMIT_DESCRIPTION.

Add this to the variables we unset when running htags, so that
the 'pages' job doesn't fail if the most recent commit happens
to have a very large commit message.

Cc: qemu-stable@nongnu.org
Fixes: 52a21689cd8 (".gitlab-ci.d/buildtest.yml: Work around htags bug when environment is large")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 .gitlab-ci.d/buildtest.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index d888a600637..37a53bf105d 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -736,7 +736,7 @@ pages:
     - make gtags
     # We unset variables to work around a bug in some htags versions
     # which causes it to fail when the environment is large
-    - CI_COMMIT_MESSAGE= CI_COMMIT_TAG_MESSAGE= htags
+    - CI_COMMIT_MESSAGE= CI_COMMIT_TAG_MESSAGE= CI_COMMIT_DESCRIPTION= htags
         -anT --tree-view=filetree -m qemu_init
         -t "Welcome to the QEMU sourcecode"
     - mv HTML public/src
-- 
2.43.0
Re: [PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags
Posted by Alex Bennée 1 month, 4 weeks ago
Peter Maydell <peter.maydell@linaro.org> writes:

> In commit 52a21689cd829 we added a workaround for a bug in older
> versions of htags where they fail with a weird error message if the
> environment is too large.  However, we missed one variable which
> gitlab CI can set to the body of the commit message:
> CI_COMMIT_DESCRIPTION.
>
> Add this to the variables we unset when running htags, so that
> the 'pages' job doesn't fail if the most recent commit happens
> to have a very large commit message.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 52a21689cd8 (".gitlab-ci.d/buildtest.yml: Work around htags bug when environment is large")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
Re: [PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags
Posted by Daniel P. Berrangé 1 month, 4 weeks ago
On Tue, Sep 16, 2025 at 05:30:30PM +0100, Peter Maydell wrote:
> In commit 52a21689cd829 we added a workaround for a bug in older
> versions of htags where they fail with a weird error message if the
> environment is too large.  However, we missed one variable which
> gitlab CI can set to the body of the commit message:
> CI_COMMIT_DESCRIPTION.
> 
> Add this to the variables we unset when running htags, so that
> the 'pages' job doesn't fail if the most recent commit happens
> to have a very large commit message.
> 
> Cc: qemu-stable@nongnu.org
> Fixes: 52a21689cd8 (".gitlab-ci.d/buildtest.yml: Work around htags bug when environment is large")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  .gitlab-ci.d/buildtest.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|