[PATCH trivial] ui/gtk: Fix callback function signature

Filip Hejsek posted 1 patch 2 weeks, 1 day ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250913-fix-signature-v1-1-974d16871432@gmail.com
Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, Laurent Vivier <laurent@vivier.eu>
ui/gtk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH trivial] ui/gtk: Fix callback function signature
Posted by Filip Hejsek 2 weeks, 1 day ago
The correct type for opaque pointer is gpointer,
not gpointer * (which is a pointer to a pointer).

Signed-off-by: Filip Hejsek <filip.hejsek@gmail.com>
---
This fixes a small mistake in callback function signature. The mistake
didn't cause any actual problems, so this patch is just code cleanup.
---
 ui/gtk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/gtk.c b/ui/gtk.c
index e91d093a49e5d05c10f1dbea5b9b94ff1389b456..f1d44402d8cd69045e0d2478b5f7a58b65d3a56c 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -766,9 +766,9 @@ static gboolean gd_render_event(GtkGLArea *area, GdkGLContext *context,
 }
 
 static void gd_resize_event(GtkGLArea *area,
-                            gint width, gint height, gpointer *opaque)
+                            gint width, gint height, gpointer opaque)
 {
-    VirtualConsole *vc = (void *)opaque;
+    VirtualConsole *vc = opaque;
     double pw = width, ph = height;
     double sx = vc->gfx.scale_x, sy = vc->gfx.scale_y;
     GdkWindow *window = gtk_widget_get_window(GTK_WIDGET(area));

---
base-commit: 190d5d7fd725ff754f94e8e0cbfb69f279c82b5d
change-id: 20250913-fix-signature-831d40e2b091

Best regards,
-- 
Filip Hejsek <filip.hejsek@gmail.com>
Re: [PATCH trivial] ui/gtk: Fix callback function signature
Posted by Michael Tokarev 2 weeks ago
On 13.09.2025 01:58, Filip Hejsek wrote:
> The correct type for opaque pointer is gpointer,
> not gpointer * (which is a pointer to a pointer).
> 
> Signed-off-by: Filip Hejsek <filip.hejsek@gmail.com>

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

and picked up for the trivial-patches tree.  Thanks!

/mjt
Re: [PATCH trivial] ui/gtk: Fix callback function signature
Posted by Alex Bennée 2 weeks, 1 day ago
Filip Hejsek <filip.hejsek@gmail.com> writes:

> The correct type for opaque pointer is gpointer,
> not gpointer * (which is a pointer to a pointer).
>
> Signed-off-by: Filip Hejsek <filip.hejsek@gmail.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro