[PATCH 5/6] tests/functional: close GDB socket in reverse debugging test

Daniel P. Berrangé posted 6 patches 2 weeks, 1 day ago
Maintainers: Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Thomas Huth <thuth@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Ani Sinha <anisinha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Zhao Liu <zhao1.liu@intel.com>
[PATCH 5/6] tests/functional: close GDB socket in reverse debugging test
Posted by Daniel P. Berrangé 2 weeks, 1 day ago
The GDB socket FD is leaked currently resulting in a warning from
python about the unclosed resource.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/functional/qemu_test/gdb.py     | 4 ++++
 tests/functional/reverse_debugging.py | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/tests/functional/qemu_test/gdb.py b/tests/functional/qemu_test/gdb.py
index 913e3b65ab..1b463e8a82 100644
--- a/tests/functional/qemu_test/gdb.py
+++ b/tests/functional/qemu_test/gdb.py
@@ -231,3 +231,7 @@ def connect(self):
 
         if self._extended_mode:
             self.set_extended_mode()
+
+    def close(self):
+        self._socket.close()
+        self._socket = None
diff --git a/tests/functional/reverse_debugging.py b/tests/functional/reverse_debugging.py
index 9c89f5c897..fbb5adbcce 100644
--- a/tests/functional/reverse_debugging.py
+++ b/tests/functional/reverse_debugging.py
@@ -186,5 +186,7 @@ def reverse_debugging(self, shift=7, args=None):
         self.check_pc(g, steps[-1])
         logger.info('successfully reached %x' % steps[-1])
 
+        g.close()
+
         logger.info('exiting gdb and qemu')
         vm.shutdown()
-- 
2.50.1


Re: [PATCH 5/6] tests/functional: close GDB socket in reverse debugging test
Posted by Alex Bennée 1 week, 6 days ago
Daniel P. Berrangé <berrange@redhat.com> writes:

> The GDB socket FD is leaked currently resulting in a warning from
> python about the unclosed resource.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro