[PATCH 2/6] tests/functional: convert reverse debug test to local gdb module

Daniel P. Berrangé posted 6 patches 2 weeks, 1 day ago
Maintainers: Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Thomas Huth <thuth@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Ani Sinha <anisinha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Zhao Liu <zhao1.liu@intel.com>
[PATCH 2/6] tests/functional: convert reverse debug test to local gdb module
Posted by Daniel P. Berrangé 2 weeks, 1 day ago
This replaces the use of Avocado for the GDBRemote class with
our in-tree copy.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/functional/reverse_debugging.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/functional/reverse_debugging.py b/tests/functional/reverse_debugging.py
index f9a1d395f1..405eb6b3b7 100644
--- a/tests/functional/reverse_debugging.py
+++ b/tests/functional/reverse_debugging.py
@@ -14,6 +14,7 @@
 
 from qemu_test import LinuxKernelTest, get_qemu_img
 from qemu_test.ports import Ports
+from qemu_test.gdb import GDBRemote
 
 
 class ReverseDebugging(LinuxKernelTest):
@@ -99,7 +100,6 @@ def vm_get_icount(vm):
         return vm.qmp('query-replay')['return']['icount']
 
     def reverse_debugging(self, shift=7, args=None):
-        from avocado.utils import gdb
         from avocado.utils import process
 
         logger = logging.getLogger('replay')
@@ -130,7 +130,7 @@ def reverse_debugging(self, shift=7, args=None):
             port = ports.find_free_port()
             vm = self.run_vm(False, shift, args, replay_path, image_path, port)
         logger.info('connecting to gdbstub')
-        g = gdb.GDBRemote('127.0.0.1', port, False, False)
+        g = GDBRemote('127.0.0.1', port, False, False)
         g.connect()
         r = g.cmd(b'qSupported')
         if b'qXfer:features:read+' in r:
-- 
2.50.1


Re: [PATCH 2/6] tests/functional: convert reverse debug test to local gdb module
Posted by Alex Bennée 1 week, 6 days ago
Daniel P. Berrangé <berrange@redhat.com> writes:

> This replaces the use of Avocado for the GDBRemote class with
> our in-tree copy.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro