This is v2 of the series. Note that v2 is almost a rewrite, so please
ignore v1, and there's no changelog too.
Fabiano fixed graceful shutdowns for multifd channels previously:
https://lore.kernel.org/qemu-devel/20250206175824.22664-1-farosas@suse.de/
However we can still see an warning when running preempt unit test on TLS,
even though migration functionality will not be affected:
QTEST_QEMU_BINARY=./qemu-system-x86_64 ./tests/qtest/migration-test --full -r /x86_64/migration/postcopy/preempt/tls/psk
...
qemu-kvm: Cannot read from TLS channel: The TLS connection was non-properly terminated.
...
It turns out this is because the crypto code only passes the ->shutdown
field into the read function, however that value can change concurrently in
another thread by a concurrent qio_channel_shutdown().
Patch 1 should fix this issue.
Patch 2-3 are something I found when looking at this problem, there's no
known issues I am aware of with them, however I still think they're
logically flawed, so I post them together here.
Please review, thanks.
Peter Xu (3):
io/crypto: Move tls premature termination handling into QIO layer
io/tls: Make qio_channel_tls_bye() always synchronous
migration: Make migration_has_failed() work even for CANCELLING
include/crypto/tlssession.h | 7 +--
include/io/channel-tls.h | 5 +-
crypto/tlssession.c | 7 +--
io/channel-tls.c | 107 ++++++++++--------------------------
migration/migration.c | 3 +-
io/trace-events | 3 +-
6 files changed, 39 insertions(+), 93 deletions(-)
--
2.50.1