[PATCH 3/4] hw/char: sifive_uart: Remove outdated comment about Tx FIFO

frank.chang@sifive.com posted 4 patches 2 weeks, 3 days ago
Maintainers: Alistair Francis <Alistair.Francis@wdc.com>, Palmer Dabbelt <palmer@dabbelt.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
[PATCH 3/4] hw/char: sifive_uart: Remove outdated comment about Tx FIFO
Posted by frank.chang@sifive.com 2 weeks, 3 days ago
From: Frank Chang <frank.chang@sifive.com>

Since Tx FIFO is now implemented using "qemu/fifo8.h", remove the comment
that no longer reflects the current implementation.

Signed-off-by: Frank Chang <frank.chang@sifive.com>
---
 hw/char/sifive_uart.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c
index 401f869680d..baef0bd9c28 100644
--- a/hw/char/sifive_uart.c
+++ b/hw/char/sifive_uart.c
@@ -28,12 +28,6 @@
 
 #define TX_INTERRUPT_TRIGGER_DELAY_NS 100
 
-/*
- * Not yet implemented:
- *
- * Transmit FIFO using "qemu/fifo8.h"
- */
-
 /* Returns the state of the IP (interrupt pending) register */
 static uint32_t sifive_uart_ip(SiFiveUARTState *s)
 {
-- 
2.49.0
Re: [PATCH 3/4] hw/char: sifive_uart: Remove outdated comment about Tx FIFO
Posted by Alistair Francis 1 week, 6 days ago
On Fri, Sep 12, 2025 at 2:08 AM <frank.chang@sifive.com> wrote:
>
> From: Frank Chang <frank.chang@sifive.com>
>
> Since Tx FIFO is now implemented using "qemu/fifo8.h", remove the comment
> that no longer reflects the current implementation.
>
> Signed-off-by: Frank Chang <frank.chang@sifive.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  hw/char/sifive_uart.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c
> index 401f869680d..baef0bd9c28 100644
> --- a/hw/char/sifive_uart.c
> +++ b/hw/char/sifive_uart.c
> @@ -28,12 +28,6 @@
>
>  #define TX_INTERRUPT_TRIGGER_DELAY_NS 100
>
> -/*
> - * Not yet implemented:
> - *
> - * Transmit FIFO using "qemu/fifo8.h"
> - */
> -
>  /* Returns the state of the IP (interrupt pending) register */
>  static uint32_t sifive_uart_ip(SiFiveUARTState *s)
>  {
> --
> 2.49.0
>
>