tests/qemu-iotests: Mark the 'inactive-node-nbd' as unsupported with -luks

[PATCH] tests/qemu-iotests: Mark the 'inactive-node-nbd' as unsupported with -luks

Posted by Thomas Huth 2 weeks, 3 days ago

From: Thomas Huth <thuth@redhat.com>

When running "./check -luks inactive-node-nbd", the test currently fails
because QEMU terminates immediately. The reason can be seen with the
"-p" parameter of the "check" script:

 qemu-system-x86_64: -blockdev luks,file=disk-file,node-name=disk-fmt,active=off:
  Parameter 'key-secret' is required for cipher

Quoting Kevin: "The test case just isn't made for luks. iotests.py has
special code for luks in VM.add_drive(), but not in VM.add_blockdev()."

Thus let's mark it as unsupported on luks to avoid the failure.

Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qemu-iotests/tests/inactive-node-nbd | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qemu-iotests/tests/inactive-node-nbd b/tests/qemu-iotests/tests/inactive-node-nbd
index a95b37e7962..664157bfd04 100755
--- a/tests/qemu-iotests/tests/inactive-node-nbd
+++ b/tests/qemu-iotests/tests/inactive-node-nbd
@@ -24,6 +24,7 @@ from iotests import QemuIoInteractive
 from iotests import filter_qemu_io, filter_qtest, filter_qmp_testfiles
 
 iotests.script_initialize(supported_fmts=['generic'],
+                          unsupported_fmts=['luks'],
                           supported_protocols=['file'],
                           supported_platforms=['linux'])
 
-- 
2.51.0

Re: [PATCH] tests/qemu-iotests: Mark the 'inactive-node-nbd' as unsupported with -luks

Posted by Kevin Wolf 2 weeks, 3 days ago

Am 11.09.2025 um 16:29 hat Thomas Huth geschrieben:
> From: Thomas Huth <thuth@redhat.com>
> 
> When running "./check -luks inactive-node-nbd", the test currently fails
> because QEMU terminates immediately. The reason can be seen with the
> "-p" parameter of the "check" script:
> 
>  qemu-system-x86_64: -blockdev luks,file=disk-file,node-name=disk-fmt,active=off:
>   Parameter 'key-secret' is required for cipher
> 
> Quoting Kevin: "The test case just isn't made for luks. iotests.py has
> special code for luks in VM.add_drive(), but not in VM.add_blockdev()."
> 
> Thus let's mark it as unsupported on luks to avoid the failure.
> 
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks, applied to the block branch.

Kevin

Re: [PATCH] tests/qemu-iotests: Mark the 'inactive-node-nbd' as unsupported with -luks

Posted by Daniel P. Berrangé 2 weeks, 3 days ago

On Thu, Sep 11, 2025 at 04:29:22PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> When running "./check -luks inactive-node-nbd", the test currently fails
> because QEMU terminates immediately. The reason can be seen with the
> "-p" parameter of the "check" script:
> 
>  qemu-system-x86_64: -blockdev luks,file=disk-file,node-name=disk-fmt,active=off:
>   Parameter 'key-secret' is required for cipher
> 
> Quoting Kevin: "The test case just isn't made for luks. iotests.py has
> special code for luks in VM.add_drive(), but not in VM.add_blockdev()."
> 
> Thus let's mark it as unsupported on luks to avoid the failure.
> 
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/qemu-iotests/tests/inactive-node-nbd | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|