[PATCH 1/3] tests/qemu-iotests/184: Fix skip message for qemu-img without throttle

Thomas Huth posted 3 patches 4 months, 4 weeks ago
Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
There is a newer version of this series
[PATCH 1/3] tests/qemu-iotests/184: Fix skip message for qemu-img without throttle
Posted by Thomas Huth 4 months, 4 weeks ago
From: Thomas Huth <thuth@redhat.com>

If qemu-img does not support throttling, test 184 currently skips
with the message:

  not suitable for this image format: raw

But that's wrong, it's not about the image format, it's about the
throttling not being available in qemu-img. Thus fix this by using
_notrun with a proper message instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qemu-iotests/184 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/184 b/tests/qemu-iotests/184
index e4cbcd86345..f7fcedacfb5 100755
--- a/tests/qemu-iotests/184
+++ b/tests/qemu-iotests/184
@@ -50,7 +50,7 @@ run_qemu()
 }
 
 test_throttle=$($QEMU_IMG --help|grep throttle)
-[ "$test_throttle" = "" ] && _supported_fmt throttle
+[ "$test_throttle" = "" ] && _notrun "qemu-img does not support throttle"
 
 echo
 echo "== checking interface =="
-- 
2.51.0
Re: [PATCH 1/3] tests/qemu-iotests/184: Fix skip message for qemu-img without throttle
Posted by Kevin Wolf 4 months, 1 week ago
Am 10.09.2025 um 17:37 hat Thomas Huth geschrieben:
> From: Thomas Huth <thuth@redhat.com>
> 
> If qemu-img does not support throttling, test 184 currently skips
> with the message:
> 
>   not suitable for this image format: raw
> 
> But that's wrong, it's not about the image format, it's about the
> throttling not being available in qemu-img. Thus fix this by using
> _notrun with a proper message instead.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>