Descriptors using this value have been shipped for years
by distros, so we just need to update the spec to match
reality.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 docs/interop/firmware.json | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
index 6bbe2cce0a..ccbfaf828d 100644
--- a/docs/interop/firmware.json
+++ b/docs/interop/firmware.json
@@ -85,12 +85,14 @@
 #
 # @loongarch64: 64-bit LoongArch. (since: 7.1)
 #
+# @riscv64: 64-bit RISC-V.
+#
 # @x86_64: 64-bit x86.
 #
 # Since: 3.0
 ##
 { 'enum' : 'FirmwareArchitecture',
-  'data' : [ 'aarch64', 'arm', 'i386', 'loongarch64', 'x86_64' ] }
+  'data' : [ 'aarch64', 'arm', 'i386', 'loongarch64', 'riscv64', 'x86_64' ] }
 
 ##
 # @FirmwareTarget:
-- 
2.51.0

On 9/10/25 15:15, Andrea Bolognani wrote:
> Descriptors using this value have been shipped for years
> by distros, so we just need to update the spec to match
> reality.

Hm.  Probably to my shame, I never shipped this file in
debian/ubuntu - neither the updated one nor the original,
and have no idea what it is used for :)

What's the context where it's used?

BTW, should I perhaps pick this change up to qemu-stable
too?

Thanks,

/mjt

On Sat, Oct 04, 2025 at 10:03:45AM +0300, Michael Tokarev wrote:
> On 9/10/25 15:15, Andrea Bolognani wrote:
> > Descriptors using this value have been shipped for years
> > by distros, so we just need to update the spec to match
> > reality.
>
> Hm.  Probably to my shame, I never shipped this file in
> debian/ubuntu - neither the updated one nor the original,
> and have no idea what it is used for :)
>
> What's the context where it's used?

I don't think the file is used directly. It just defines what
firmware descriptors (shipped by edk2 and other firmware packages)
should look like.

> BTW, should I perhaps pick this change up to qemu-stable
> too?

No harm in doing that, but I would say it's unnecessary.

-- 
Andrea Bolognani / Red Hat / Virtualization

On Wed, Sep 10, 2025 at 10:16 PM Andrea Bolognani <abologna@redhat.com> wrote:
>
> Descriptors using this value have been shipped for years
> by distros, so we just need to update the spec to match
> reality.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>  docs/interop/firmware.json | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
> index 6bbe2cce0a..ccbfaf828d 100644
> --- a/docs/interop/firmware.json
> +++ b/docs/interop/firmware.json
> @@ -85,12 +85,14 @@
>  #
>  # @loongarch64: 64-bit LoongArch. (since: 7.1)
>  #
> +# @riscv64: 64-bit RISC-V.
> +#
>  # @x86_64: 64-bit x86.
>  #
>  # Since: 3.0
>  ##
>  { 'enum' : 'FirmwareArchitecture',
> -  'data' : [ 'aarch64', 'arm', 'i386', 'loongarch64', 'x86_64' ] }
> +  'data' : [ 'aarch64', 'arm', 'i386', 'loongarch64', 'riscv64', 'x86_64' ] }
>
>  ##
>  # @FirmwareTarget:
> --
> 2.51.0
>
>

On Wed, Sep 10, 2025 at 2:15 PM Andrea Bolognani <abologna@redhat.com> wrote:
>
> Descriptors using this value have been shipped for years
> by distros, so we just need to update the spec to match
> reality.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  docs/interop/firmware.json | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
> index 6bbe2cce0a..ccbfaf828d 100644
> --- a/docs/interop/firmware.json
> +++ b/docs/interop/firmware.json
> @@ -85,12 +85,14 @@
>  #
>  # @loongarch64: 64-bit LoongArch. (since: 7.1)
>  #
> +# @riscv64: 64-bit RISC-V.
> +#
>  # @x86_64: 64-bit x86.
>  #
>  # Since: 3.0
>  ##
>  { 'enum' : 'FirmwareArchitecture',
> -  'data' : [ 'aarch64', 'arm', 'i386', 'loongarch64', 'x86_64' ] }
> +  'data' : [ 'aarch64', 'arm', 'i386', 'loongarch64', 'riscv64', 'x86_64' ] }

Thanks :-)

Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com>

>  ##
>  # @FirmwareTarget:
> --
> 2.51.0
>