[PULL 0/8] Tracing patches

Stefan Hajnoczi posted 8 patches 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250908140653.170707-1-stefanha@redhat.com
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Mads Ynddal <mads@ynddal.dk>, Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>
There is a newer version of this series
MAINTAINERS                                  |   1 +
docs/devel/testing/main.rst                  |  40 +++++++
tests/Makefile.include                       |   1 +
tests/tracetool/dtrace.h                     |  45 ++++++++
tests/tracetool/ftrace.h                     |  59 ++++++++++
tests/tracetool/log.h                        |  43 ++++++++
tests/tracetool/simple.h                     |  40 +++++++
tests/tracetool/syslog.h                     |  43 ++++++++
tests/tracetool/ust.h                        |  41 +++++++
tests/tracetool/dtrace.c                     |  32 ++++++
tests/tracetool/ftrace.c                     |  32 ++++++
tests/tracetool/log.c                        |  32 ++++++
tests/tracetool/simple.c                     |  61 +++++++++++
tests/tracetool/syslog.c                     |  32 ++++++
tests/tracetool/ust.c                        |  32 ++++++
scripts/checkpatch.pl                        |   3 +
scripts/tracetool/__init__.py                |   9 +-
scripts/tracetool/format/c.py                |   3 +-
scripts/tracetool/format/d.py                |   3 +-
scripts/tracetool/format/h.py                |  17 +--
scripts/tracetool/format/log_stap.py         |   1 +
scripts/tracetool/format/simpletrace_stap.py |   1 +
scripts/tracetool/format/stap.py             |   1 +
scripts/tracetool/format/ust_events_c.py     |   1 +
scripts/tracetool/format/ust_events_h.py     |   1 +
tests/meson.build                            |   1 +
tests/qapi-schema/test-qapi.py               |   7 +-
tests/tracetool/dtrace.d                     |  10 ++
tests/tracetool/dtrace.log-stap              |  15 +++
tests/tracetool/dtrace.simpletrace-stap      |  16 +++
tests/tracetool/dtrace.stap                  |  14 +++
tests/tracetool/meson.build                  |  25 +++++
tests/tracetool/trace-events                 |   5 +
tests/tracetool/tracetool-test.py            | 107 +++++++++++++++++++
tests/tracetool/ust.ust-events-c             |  14 +++
tests/tracetool/ust.ust-events-h             |  56 ++++++++++
36 files changed, 823 insertions(+), 21 deletions(-)
create mode 100644 tests/tracetool/dtrace.h
create mode 100644 tests/tracetool/ftrace.h
create mode 100644 tests/tracetool/log.h
create mode 100644 tests/tracetool/simple.h
create mode 100644 tests/tracetool/syslog.h
create mode 100644 tests/tracetool/ust.h
create mode 100644 tests/tracetool/dtrace.c
create mode 100644 tests/tracetool/ftrace.c
create mode 100644 tests/tracetool/log.c
create mode 100644 tests/tracetool/simple.c
create mode 100644 tests/tracetool/syslog.c
create mode 100644 tests/tracetool/ust.c
create mode 100644 tests/tracetool/dtrace.d
create mode 100644 tests/tracetool/dtrace.log-stap
create mode 100644 tests/tracetool/dtrace.simpletrace-stap
create mode 100644 tests/tracetool/dtrace.stap
create mode 100644 tests/tracetool/meson.build
create mode 100644 tests/tracetool/trace-events
create mode 100755 tests/tracetool/tracetool-test.py
create mode 100644 tests/tracetool/ust.ust-events-c
create mode 100644 tests/tracetool/ust.ust-events-h
[PULL 0/8] Tracing patches
Posted by Stefan Hajnoczi 5 months ago
The following changes since commit 6a9fa5ef3230a7d51e0d953a59ee9ef10af705b8:

  Merge tag 'pull-tcg-20250905' of https://gitlab.com/rth7680/qemu into staging (2025-09-05 09:51:27 +0200)

are available in the Git repository at:

  https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to b91cbf4e691b397510584b04fd6197284f55b52c:

  tracetool-test: allow to run in parallel (2025-09-08 09:48:10 -0400)

----------------------------------------------------------------
Pull request

Daniel Berrangé's tracetool test suite and Marc-André Lureau's test suite fix.

----------------------------------------------------------------

Daniel P. Berrangé (7):
  checkpatch: cull trailing '*/' in SPDX check
  tracetool: eliminate trailing whitespace in C format
  tracetool: avoid space after "*" in arg types
  tracetool: include SPDX-License-Identifier in generated files
  tracetool: add test suite for tracetool with reference output
  tracetool: drop the probe "__nocheck__" wrapping
  qapi: switch to use QEMU_TEST_REGENERATE env var

Marc-André Lureau (1):
  tracetool-test: allow to run in parallel

 MAINTAINERS                                  |   1 +
 docs/devel/testing/main.rst                  |  40 +++++++
 tests/Makefile.include                       |   1 +
 tests/tracetool/dtrace.h                     |  45 ++++++++
 tests/tracetool/ftrace.h                     |  59 ++++++++++
 tests/tracetool/log.h                        |  43 ++++++++
 tests/tracetool/simple.h                     |  40 +++++++
 tests/tracetool/syslog.h                     |  43 ++++++++
 tests/tracetool/ust.h                        |  41 +++++++
 tests/tracetool/dtrace.c                     |  32 ++++++
 tests/tracetool/ftrace.c                     |  32 ++++++
 tests/tracetool/log.c                        |  32 ++++++
 tests/tracetool/simple.c                     |  61 +++++++++++
 tests/tracetool/syslog.c                     |  32 ++++++
 tests/tracetool/ust.c                        |  32 ++++++
 scripts/checkpatch.pl                        |   3 +
 scripts/tracetool/__init__.py                |   9 +-
 scripts/tracetool/format/c.py                |   3 +-
 scripts/tracetool/format/d.py                |   3 +-
 scripts/tracetool/format/h.py                |  17 +--
 scripts/tracetool/format/log_stap.py         |   1 +
 scripts/tracetool/format/simpletrace_stap.py |   1 +
 scripts/tracetool/format/stap.py             |   1 +
 scripts/tracetool/format/ust_events_c.py     |   1 +
 scripts/tracetool/format/ust_events_h.py     |   1 +
 tests/meson.build                            |   1 +
 tests/qapi-schema/test-qapi.py               |   7 +-
 tests/tracetool/dtrace.d                     |  10 ++
 tests/tracetool/dtrace.log-stap              |  15 +++
 tests/tracetool/dtrace.simpletrace-stap      |  16 +++
 tests/tracetool/dtrace.stap                  |  14 +++
 tests/tracetool/meson.build                  |  25 +++++
 tests/tracetool/trace-events                 |   5 +
 tests/tracetool/tracetool-test.py            | 107 +++++++++++++++++++
 tests/tracetool/ust.ust-events-c             |  14 +++
 tests/tracetool/ust.ust-events-h             |  56 ++++++++++
 36 files changed, 823 insertions(+), 21 deletions(-)
 create mode 100644 tests/tracetool/dtrace.h
 create mode 100644 tests/tracetool/ftrace.h
 create mode 100644 tests/tracetool/log.h
 create mode 100644 tests/tracetool/simple.h
 create mode 100644 tests/tracetool/syslog.h
 create mode 100644 tests/tracetool/ust.h
 create mode 100644 tests/tracetool/dtrace.c
 create mode 100644 tests/tracetool/ftrace.c
 create mode 100644 tests/tracetool/log.c
 create mode 100644 tests/tracetool/simple.c
 create mode 100644 tests/tracetool/syslog.c
 create mode 100644 tests/tracetool/ust.c
 create mode 100644 tests/tracetool/dtrace.d
 create mode 100644 tests/tracetool/dtrace.log-stap
 create mode 100644 tests/tracetool/dtrace.simpletrace-stap
 create mode 100644 tests/tracetool/dtrace.stap
 create mode 100644 tests/tracetool/meson.build
 create mode 100644 tests/tracetool/trace-events
 create mode 100755 tests/tracetool/tracetool-test.py
 create mode 100644 tests/tracetool/ust.ust-events-c
 create mode 100644 tests/tracetool/ust.ust-events-h

-- 
2.51.0


Re: [PULL 0/8] Tracing patches
Posted by Peter Maydell 5 months ago
On Mon, 8 Sept 2025 at 15:10, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 6a9fa5ef3230a7d51e0d953a59ee9ef10af705b8:
>
>   Merge tag 'pull-tcg-20250905' of https://gitlab.com/rth7680/qemu into staging (2025-09-05 09:51:27 +0200)
>
> are available in the Git repository at:
>
>   https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to b91cbf4e691b397510584b04fd6197284f55b52c:
>
>   tracetool-test: allow to run in parallel (2025-09-08 09:48:10 -0400)
>
> ----------------------------------------------------------------
> Pull request
>
> Daniel Berrangé's tracetool test suite and Marc-André Lureau's test suite fix.
>
> ----------------------------------------------------------------

I ran this as a combined merge test with a couple of other
pullreqs, but I'm assuming this one is the cause of this
msys2-64bit job failure:

https://gitlab.com/qemu-project/qemu/-/jobs/11318561687

# [WinError 2] The system cannot find the file specified:
'C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/tracetooldmg99xan/dtrace.c'
not ok 1 - dtrace.c (set QEMU_TEST_REGENERATE=1 to recreate reference
output if tracetool generator was intentionally changed)
# [WinError 2] The system cannot find the file specified:
'C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/tracetooldmg99xan/dtrace.h'

and other similar errors.

thanks
-- PMM
Re: [PULL 0/8] Tracing patches
Posted by Stefan Hajnoczi 4 months, 4 weeks ago
On Thu, Sep 11, 2025 at 7:40 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 8 Sept 2025 at 15:10, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > The following changes since commit 6a9fa5ef3230a7d51e0d953a59ee9ef10af705b8:
> >
> >   Merge tag 'pull-tcg-20250905' of https://gitlab.com/rth7680/qemu into staging (2025-09-05 09:51:27 +0200)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request
> >
> > for you to fetch changes up to b91cbf4e691b397510584b04fd6197284f55b52c:
> >
> >   tracetool-test: allow to run in parallel (2025-09-08 09:48:10 -0400)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > Daniel Berrangé's tracetool test suite and Marc-André Lureau's test suite fix.
> >
> > ----------------------------------------------------------------
>
> I ran this as a combined merge test with a couple of other
> pullreqs, but I'm assuming this one is the cause of this
> msys2-64bit job failure:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/11318561687
>
> # [WinError 2] The system cannot find the file specified:
> 'C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/tracetooldmg99xan/dtrace.c'
> not ok 1 - dtrace.c (set QEMU_TEST_REGENERATE=1 to recreate reference
> output if tracetool generator was intentionally changed)
> # [WinError 2] The system cannot find the file specified:
> 'C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/tracetooldmg99xan/dtrace.h'
>
> and other similar errors.

Hi Daniel,
Looks like Windows is not happy with the new tracetool test suite.
Please take a look at
https://gitlab.com/qemu-project/qemu/-/jobs/11318561687.

Stefan

>
> thanks
> -- PMM
>
Re: [PULL 0/8] Tracing patches
Posted by Daniel P. Berrangé 4 months, 3 weeks ago
On Thu, Sep 11, 2025 at 04:49:57PM -0400, Stefan Hajnoczi wrote:
> On Thu, Sep 11, 2025 at 7:40 AM Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Mon, 8 Sept 2025 at 15:10, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > >
> > > The following changes since commit 6a9fa5ef3230a7d51e0d953a59ee9ef10af705b8:
> > >
> > >   Merge tag 'pull-tcg-20250905' of https://gitlab.com/rth7680/qemu into staging (2025-09-05 09:51:27 +0200)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request
> > >
> > > for you to fetch changes up to b91cbf4e691b397510584b04fd6197284f55b52c:
> > >
> > >   tracetool-test: allow to run in parallel (2025-09-08 09:48:10 -0400)
> > >
> > > ----------------------------------------------------------------
> > > Pull request
> > >
> > > Daniel Berrangé's tracetool test suite and Marc-André Lureau's test suite fix.
> > >
> > > ----------------------------------------------------------------
> >
> > I ran this as a combined merge test with a couple of other
> > pullreqs, but I'm assuming this one is the cause of this
> > msys2-64bit job failure:
> >
> > https://gitlab.com/qemu-project/qemu/-/jobs/11318561687
> >
> > # [WinError 2] The system cannot find the file specified:
> > 'C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/tracetooldmg99xan/dtrace.c'
> > not ok 1 - dtrace.c (set QEMU_TEST_REGENERATE=1 to recreate reference
> > output if tracetool generator was intentionally changed)
> > # [WinError 2] The system cannot find the file specified:
> > 'C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/tracetooldmg99xan/dtrace.h'
> >
> > and other similar errors.
> 
> Hi Daniel,
> Looks like Windows is not happy with the new tracetool test suite.
> Please take a look at
> https://gitlab.com/qemu-project/qemu/-/jobs/11318561687.

It was unhappy with spawning child processes on Windows for reasons
that I've been unable to diagnose. Since the purpose of the test is
simply to match the generated code output  against reference output,
I decided to just disable it on Windows, and sent a v5 wit that.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PULL 0/8] Tracing patches
Posted by Daniel P. Berrangé 4 months, 4 weeks ago
On Thu, Sep 11, 2025 at 04:49:57PM -0400, Stefan Hajnoczi wrote:
> On Thu, Sep 11, 2025 at 7:40 AM Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Mon, 8 Sept 2025 at 15:10, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > >
> > > The following changes since commit 6a9fa5ef3230a7d51e0d953a59ee9ef10af705b8:
> > >
> > >   Merge tag 'pull-tcg-20250905' of https://gitlab.com/rth7680/qemu into staging (2025-09-05 09:51:27 +0200)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request
> > >
> > > for you to fetch changes up to b91cbf4e691b397510584b04fd6197284f55b52c:
> > >
> > >   tracetool-test: allow to run in parallel (2025-09-08 09:48:10 -0400)
> > >
> > > ----------------------------------------------------------------
> > > Pull request
> > >
> > > Daniel Berrangé's tracetool test suite and Marc-André Lureau's test suite fix.
> > >
> > > ----------------------------------------------------------------
> >
> > I ran this as a combined merge test with a couple of other
> > pullreqs, but I'm assuming this one is the cause of this
> > msys2-64bit job failure:
> >
> > https://gitlab.com/qemu-project/qemu/-/jobs/11318561687
> >
> > # [WinError 2] The system cannot find the file specified:
> > 'C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/tracetooldmg99xan/dtrace.c'
> > not ok 1 - dtrace.c (set QEMU_TEST_REGENERATE=1 to recreate reference
> > output if tracetool generator was intentionally changed)
> > # [WinError 2] The system cannot find the file specified:
> > 'C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/tracetooldmg99xan/dtrace.h'
> >
> > and other similar errors.
> 
> Hi Daniel,
> Looks like Windows is not happy with the new tracetool test suite.
> Please take a look at
> https://gitlab.com/qemu-project/qemu/-/jobs/11318561687.

Yep, will investigate and get back to you.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|